Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
06 infercnv pr1013 14 #1026
06 infercnv pr1013 14 #1026
Changes from 3 commits
1018964
ad0fcaa
96ca94b
0cb3908
adae499
2ad8f7d
40f2677
ac6c788
eb16532
52a86f3
0c4c77a
7addaca
d00f3b3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't actually seem like there are any duplicated ENSG ids here. I compared the number of rows with and without this line, and it's the same. So, one question is: How are some of these genes you're thinking of shown in this data frame? Are they on the correct chromosome, or do we have a different parsing problem?
If the data looks fine, then this line can be deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right, I had previously problems with genes common on X and Y chromosomes, but it seems that there are not in the gene position file downloaded from aws.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the data looks fine to me, there is only one gene that I had previously and we are missing now, no idea why but I don't think it will impact the following analysis:
![image](https://private-user-images.githubusercontent.com/100755946/410031164-522fd063-2b3b-491f-b957-d6e4a35211a8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NjM4MTcsIm5iZiI6MTczODk2MzUxNywicGF0aCI6Ii8xMDA3NTU5NDYvNDEwMDMxMTY0LTUyMmZkMDYzLTJiM2ItNDkxZi1iOTU3LWQ2ZTRhMzUyMTFhOC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QyMTI1MTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04YmU3MWE0MDY3OTdlNDlhMThjZDRjZjMyNjcyNTQ0YjM1ZGU2ZGFmZTEzNDhhMWEyYmY1NTIwMDVmZjEyYjRiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.wf0xx2NG5Pja54BJN2kN-JygC9EyJpzUvp6lSsjL3j0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comparing the number of genes per arms with my previous code and the one here, we only have this one gene on chr9p difference
![image](https://private-user-images.githubusercontent.com/100755946/410032887-5c811a01-44fc-4055-8db8-0eb6714476d9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NjM4MTcsIm5iZiI6MTczODk2MzUxNywicGF0aCI6Ii8xMDA3NTU5NDYvNDEwMDMyODg3LTVjODExYTAxLTQ0ZmMtNDA1NS04ZGI4LTBlYjY3MTQ0NzZkOS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QyMTI1MTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yYjQwYzFiYTU0OWE1N2JjOWYyZTVkMjAzMzZmYjlhNjBhMzhjMjFlNGZkNWNmYzExMTM4YWU3MzdiMjAxYjFkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.xfDsppnEu67DgDOGiwOo5MXhj1x5bUKRwpPMkCbGqN4)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, so we can remove this line! I had a look at this gene, and I can't imagine it will cause a problem: https://www.genecards.org/cgi-bin/carddisp.pl?gene=GXYLT1P5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and finally comparing random positions in the two tables, we find the exact same gene/arm/coordinates:
![image](https://private-user-images.githubusercontent.com/100755946/410034010-7171ab11-69d6-4729-81ac-5fc4187ba028.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NjM4MTcsIm5iZiI6MTczODk2MzUxNywicGF0aCI6Ii8xMDA3NTU5NDYvNDEwMDM0MDEwLTcxNzFhYjExLTY5ZDYtNDcyOS04MWFjLTVmYzQxODdiYTAyOC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QyMTI1MTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yZThmYjYzMTBlZDVlZTA0MWU2MTc0Y2Y3NmIxMDMzNjk0YTcyZmEzZDk5ODUyMjRlYmIwYzExYTdkYTFmNzE5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.8QTqrPQBM63rxoP5pc9BvaJb4IEXmogT4zJAWL-td0k)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so I am quite confident about the gene position file created 😄