Add push trigger to Wilms tumor cell typing Docker build/push workflow & proposed change to template #688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
Here, I'm adding a GitHub Actions workflow trigger that will push the Docker images for the
cell-type-wilms-tumor-06
module to ECR upon merge tomain
.I meant to accomplish this in maud-p#3, but I was (arguably overly!) focused on aligning the changes with the template.
That made me wonder why these commented-out steps are not in the template, so I've added them. I could see an argument for not including them–we want to make sure something is sufficiently mature before pushing–but I don't know that the pull request trigger and push trigger need to be uncommented at the same time.
Please link to the GitHub issue that this pull request addresses.
N/A
Provide directions for reviewers
What do you think of this change to the template? I admit there maybe should be docs changes as well, but I wanted to discuss this first!