Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add push trigger to Wilms tumor cell typing Docker build/push workflow & proposed change to template #688

Merged

Conversation

jaclyn-taroni
Copy link
Member

Purpose/implementation Section

Here, I'm adding a GitHub Actions workflow trigger that will push the Docker images for the cell-type-wilms-tumor-06 module to ECR upon merge to main.

I meant to accomplish this in maud-p#3, but I was (arguably overly!) focused on aligning the changes with the template.

That made me wonder why these commented-out steps are not in the template, so I've added them. I could see an argument for not including them–we want to make sure something is sufficiently mature before pushing–but I don't know that the pull request trigger and push trigger need to be uncommented at the same time.

Please link to the GitHub issue that this pull request addresses.

N/A

Provide directions for reviewers

What do you think of this change to the template? I admit there maybe should be docs changes as well, but I wanted to discuss this first!

Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with the change to the template; I think I simply forgot to add it when I was trying different approaches to building and pushing.

@jaclyn-taroni
Copy link
Member Author

Thanks! I don't think there are any docs changes required, having reviewed the comments at the top of the YAML + the ensuring reproducibility docs.

@jaclyn-taroni jaclyn-taroni merged commit c25dc49 into AlexsLemonade:main Aug 5, 2024
2 checks passed
@jaclyn-taroni jaclyn-taroni deleted the jaclyn-taroni/wilms-push branch August 5, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants