Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some words to dictionary #721

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

sjspielman
Copy link
Member

Closes #719

This PR adds some of the found typos to the dictionary. Some choices I made:

  • I added...
    • "podman" since that is the container software used in the wilms module, but I could alternatively remove it and we could later update it to be podman in the module if preferred.
    • unhide." If that's the word R Markdown uses, I guess that's the word!
  • I didn't add...
    • Gene names or words that appear in DOIs (e.g. "oncotarget") since we expect to add those in backticks eventually
    • The cell type "Treg". Should I, or will we eventually want things like that in backticks?

Let me know if you think I missed anything! Here are the typos from #719: spell_check_errors.tsv.txt

@sjspielman sjspielman requested review from jashapiro and removed request for jaclyn-taroni August 15, 2024 14:01
Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably go ahead and add gene names, since the standard formatting for those is italics in text, and I expect that to be used most of the time.

I would also add "snRNA" (and "scRNA while we are at it?)

@sjspielman
Copy link
Member Author

I would also add "snRNA"

Ugh I did, but didn't push... thanks

@sjspielman sjspielman merged commit 38ec553 into AlexsLemonade:main Aug 15, 2024
3 checks passed
@sjspielman sjspielman deleted the sjspielman/719-dictionary branch August 15, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monthly spellcheck results
2 participants