Add download option to sync script #751
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/AlexsLemonade/OpenScPCA-admin/issues/257
Here I added a
--download
flag to the existingsync-results.py
script. At the moment, this option works quite simply to reverse the source and destination for the internalaws
sync command, and should allow downloading from a results bucket with code like the following, (assuming the sso login has been performed):All of the other options continue to work, so to use a different profile from the currently active one and perform a dry run, you would add options as follows:
My only other thought here is that it might be nice to have the bucket autopopulate for each module if we had a file somewhere that stored the bucket name, such as
<module>/.aws_bucket
which could save a bit of repeated manual checking. But that could be a later PR.