Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download option to sync script #751

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

jashapiro
Copy link
Member

closes https://github.com/AlexsLemonade/OpenScPCA-admin/issues/257

Here I added a --download flag to the existing sync-results.py script. At the moment, this option works quite simply to reverse the source and destination for the internal aws sync command, and should allow downloading from a results bucket with code like the following, (assuming the sso login has been performed):

python scripts/sync-results.py cell-type-wilms-tumor-06  --bucket researcher-008971640512-us-east-2 --download

All of the other options continue to work, so to use a different profile from the currently active one and perform a dry run, you would add options as follows:

python scripts/sync-results.py cell-type-wilms-tumor-06  --bucket researcher-008971640512-us-east-2 --download --profile workload --dryrun

My only other thought here is that it might be nice to have the bucket autopopulate for each module if we had a file somewhere that stored the bucket name, such as <module>/.aws_bucket which could save a bit of repeated manual checking. But that could be a later PR.

Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working as expected in my local testing 👍🏻

@jashapiro
Copy link
Member Author

Seems to be working as expected in my local testing 👍🏻

Great! I was hoping this would do everything you needed, but I wasn't 100% sure if there might be any other expectations.

@jashapiro jashapiro merged commit 9ab1b6d into AlexsLemonade:main Sep 13, 2024
2 checks passed
@jashapiro jashapiro deleted the jashapiro/sync-down branch September 13, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants