-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract PC matrix within clustering function (2/2) #759
Extract PC matrix within clustering function (2/2) #759
Conversation
…_clusters and out of extract_pc_matrix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you may have overcomplicated things! The extract function you had already did all the conversions and checks, so let it handle that. I made a suggestion that I feel like ought to work with pretty minimal code changes, if you revert the extract function to its previous form.
Me?! But in all seriousness, yes. What you have suggested is more or less my first commit, so I'll just revert and get back on track there! |
…alculate_clusters and out of extract_pc_matrix" This reverts commit 22b15fa.
Just write something like "optional pc_name argument passed to extract_pc_matrix" |
Should be ready for a real look now. Note that I ended up exporting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with one little comment about column name checks.
Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org>
Closes #754
This PR does the second half of #754 and allows
calculate_clusters()
to take a single-cell object instead of only a matrix.I'm opening this as a draft because I couldn't pick between two ways of doing this..so I implemented them both. Which general approach should we go with (noting it might be a little bit "why not both"!)?
calculate_clusters()
function and left the extract pc function alone. While writing docs for it though, it felt odd strange to describe the defaultpc_name
argument behavior in the clustering function when the extract function was actually defining those defaults. I then wondered if too much was getting duplicated, so I then...