Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initiation of new Glioblastoma analysis module #783

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

georginaalbadri
Copy link
Contributor

Purpose/implementation Section

This pull request is to provide the template and draft README for a new analysis module for Glioblastoma, for project SCPCP000001.

Please link to the GitHub issue that this pull request addresses.

Issue 778

What is the goal of this pull request?

Initiation of the Python analysis module

Briefly describe the general approach you took to achieve this goal.

I ran create-analysis-module.py with handles --use-python, --use-jupyter, --use-conda

If known, do you anticipate filing additional pull requests to complete this analysis module?

Yes

Output of create_analysis_module.py with python, jupyter and conda flags
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jaclyn-taroni jaclyn-taroni requested review from jashapiro and removed request for jaclyn-taroni September 27, 2024 12:15
Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @georginaalbadri,

Thank you for your initial cointribution to OpenScPCA! Everything here looks good, with one comment about the format of the data download that might make things easier for your future work.

I also suggested adding celltypist as a dependency to the conda environment, as we may as well get that done now. If there are any other packages that you will need that you might know about already, you could add those as well.

Finally, I noticed that you are using your main branch for this pull request. That is fine, especially at this stage, but in the future I would suggest making new branches in your fork for each new pull request, as that will make it easier for you to potentially work on different phases of the analysis while one part is in review or if you need to keep things separate for other reasons.

analyses/celltype-glioblastoma/README.md Outdated Show resolved Hide resolved
georginaalbadri and others added 2 commits October 1, 2024 10:31
Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org>
Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org>
@georginaalbadri
Copy link
Contributor Author

Thanks for your additions, hopefully it is good to go! I will bear in mind using different branches for pull requests going forward

Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you again for your first contribution @georginaalbadri, and I look forward to seeing the next steps in your analysis!

@jashapiro jashapiro merged commit f808c00 into AlexsLemonade:main Oct 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants