-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initiation of new Glioblastoma analysis module #783
Conversation
Output of create_analysis_module.py with python, jupyter and conda flags
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @georginaalbadri,
Thank you for your initial cointribution to OpenScPCA! Everything here looks good, with one comment about the format of the data download that might make things easier for your future work.
I also suggested adding celltypist
as a dependency to the conda environment, as we may as well get that done now. If there are any other packages that you will need that you might know about already, you could add those as well.
Finally, I noticed that you are using your main
branch for this pull request. That is fine, especially at this stage, but in the future I would suggest making new branches in your fork for each new pull request, as that will make it easier for you to potentially work on different phases of the analysis while one part is in review or if you need to keep things separate for other reasons.
Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org>
Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org>
Thanks for your additions, hopefully it is good to go! I will bear in mind using different branches for pull requests going forward |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you again for your first contribution @georginaalbadri, and I look forward to seeing the next steps in your analysis!
Purpose/implementation Section
This pull request is to provide the template and draft README for a new analysis module for Glioblastoma, for project SCPCP000001.
Please link to the GitHub issue that this pull request addresses.
Issue 778
What is the goal of this pull request?
Initiation of the Python analysis module
Briefly describe the general approach you took to achieve this goal.
I ran create-analysis-module.py with handles --use-python, --use-jupyter, --use-conda
If known, do you anticipate filing additional pull requests to complete this analysis module?
Yes