Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initiate module for consensus cell typing #903

Conversation

allyhawkins
Copy link
Member

Purpose/implementation Section

Please link to the GitHub issue that this pull request addresses.

Closes #886

What is the goal of this pull request?

Here I am just initiating the module to be used for exploring the creation of consensus cell type labels.

Briefly describe the general approach you took to achieve this goal.

I ran the ./create-analysis-module.py script with the --use-renv flag. I am not totally sure if I'm going to use R and Python but I was pretty confident I would have at least R so am starting there.

I named this module cell-type-consensus and followed the same format we've been using for naming other cell type modules. Let me know if you prefer a different name.

The last thing I did was update the README briefly by adding a very brief summary of what is included in this module and then TBD for the other sections. I plan on updating this as we add to the module but thought this was sufficient for now.

If known, do you anticipate filing additional pull requests to complete this analysis module?

Absolutely. Next up I'll be creating a table with cell ontology IDs for cell types in the CellAssign reference.

Author checklists

Analysis module and review

Reproducibility checklist

  • Code in this pull request has been added to the GitHub Action workflow that runs this module.
  • The dependencies required to run the code in this pull request have been added to the analysis module Dockerfile.
  • If applicable, the dependencies required to run the code in this pull request have been added to the analysis module conda environment.yml file.
  • If applicable, R package dependencies required to run the code in this pull request have been added to the analysis module renv.lock file.

Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming and description LGTM 👍🏻

But I'd probably take out the notebook template before merging (somewhat a personal preference)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably remove this!

@allyhawkins allyhawkins merged commit c82ab97 into AlexsLemonade:main Nov 19, 2024
2 checks passed
@allyhawkins allyhawkins deleted the allyhawkins/initiate-cell-type-consensus branch November 19, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initiate module for identifying consensus cell type labels between SingleR and CellAssign
2 participants