Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github actions to use 1password #482

Merged
merged 14 commits into from
Aug 1, 2023
Merged

Conversation

jashapiro
Copy link
Member

Purpose

Update the github actions to use 1Password for secret management

Issue addressed

closes https://github.com/AlexsLemonade/AdminItems/issues/900

Gotchas the reviewer should know about

I updated a number of actions along the way here to avoid likely github warnings, though I anticipate there may be more. I will be running some tests after filing this to make sure everything is working as expected!

Remaining concerns and questions

We'll see how the testing goes!

@jashapiro
Copy link
Member Author

I have checked this with docker build and styling workflows, and things seem to work (after some fiddling).

The remaining workflows run fully either on merge to staging or master (docker-build-push.yml), or on a PR to master(check-frontend-urls.yml), so they have not been fully tested. However, I did check the build to make sure that the hard steps (aside from pushes) run, and it was able to render pages and login to docker.

The frontend url check has fewer changes (just to meet modern GHA standards), so I don't anticipate trouble there either.

I think this is ready for review.

Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM, thanks!

@jashapiro jashapiro merged commit c43ca15 into staging Aug 1, 2023
2 checks passed
@jashapiro jashapiro deleted the jashapiro/op-secrets branch August 1, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants