-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update github actions to use 1password #482
Conversation
use updated cacheing
This reverts commit fc8b78b.
I have checked this with docker build and styling workflows, and things seem to work (after some fiddling). The remaining workflows run fully either on merge to The frontend url check has fewer changes (just to meet modern GHA standards), so I don't anticipate trouble there either. I think this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 LGTM, thanks!
Purpose
Update the github actions to use 1Password for secret management
Issue addressed
closes https://github.com/AlexsLemonade/AdminItems/issues/900
Gotchas the reviewer should know about
I updated a number of actions along the way here to avoid likely github warnings, though I anticipate there may be more. I will be running some tests after filing this to make sure everything is working as expected!
Remaining concerns and questions
We'll see how the testing goes!