Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot navigate forward on browser #141

Closed
dvenprasad opened this issue Jul 10, 2018 · 1 comment
Closed

Cannot navigate forward on browser #141

dvenprasad opened this issue Jul 10, 2018 · 1 comment
Assignees

Comments

@dvenprasad
Copy link
Member

From the search results page, navigate to an experiment page, then hit the back button on the browser. This takes the user back to the search page but cannot use the forward button on the browser to go back to the experiment page.

@wvauclain wvauclain self-assigned this Jul 31, 2018
@jaclyn-taroni jaclyn-taroni added this to the Tambourine Tesla milestone Jul 31, 2018
@wvauclain wvauclain mentioned this issue Jul 31, 2018
7 tasks
@ghost ghost added review and removed in progress labels Jul 31, 2018
@ghost ghost removed the review label Aug 1, 2018
@arielsvn arielsvn mentioned this issue Aug 15, 2018
7 tasks
@arielsvn
Copy link
Contributor

For the record: This bug was caused because we always update the browser url after every search. This is done by calling history.push. When navigating back from an experiment page, this update is triggered, which adds a new entry in the browser history removing the entry for the experiments page, and disabling the forward arrow.

This is the default behavior of history.push, adding a new entry in the browser history even though there won't be any change in the url. There's some discussion around it, such as remix-run/history#470.

I used some of the suggestions and modified the behavior of history in 604b269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants