Fix default device_class for binary sensor #779

AlexxIT · May 3, 2022 · 51ed581 · 51ed581
1 parent 51e15fa
commit 51ed581
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/custom_components/sonoff/binary_sensor.py b/custom_components/sonoff/binary_sensor.py
@@ -29,9 +29,9 @@ async def async_setup_entry(hass, config_entry, add_entities):
 class XBinarySensor(XEntity, BinarySensorEntity):
     def __init__(self, ewelink: XRegistry, device: dict):
         XEntity.__init__(self, ewelink, device)
-        self._attr_device_class = DEVICE_CLASSES.get(
-            device.get("device_class")
-        )
+        device_class = device.get("device_class")
+        if device_class in DEVICE_CLASSES:
+            self._attr_device_class = DEVICE_CLASSES[device_class]
 
 
 # noinspection PyAbstractClass

diff --git a/tests/test_entity.py b/tests/test_entity.py
@@ -553,15 +553,11 @@ def test_wifi_sensor():
             "switch": "off",
             "type": 4
         }
-    }, {
-        "devices": {
-            DEVICEID: {"device_class": "window"}
-        }
     })
 
     sensor: XBinarySensor = entities[0]
     assert sensor.state == "off"
-    assert sensor.device_class == BinarySensorDeviceClass.WINDOW
+    assert sensor.device_class == BinarySensorDeviceClass.DOOR
     assert sensor.available is False
 
     sensor.ewelink.cloud.online = True