Fix expected device class for energy_day sensor #1377

AlexxIT · Apr 16, 2024 · fa07f4c · fa07f4c
1 parent 153aa39
commit fa07f4c
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 2 deletions.
diff --git a/custom_components/sonoff/sensor.py b/custom_components/sonoff/sensor.py
@@ -80,7 +80,9 @@ def __init__(self, ewelink: XRegistry, device: dict):
         default_class = (
             self.uid[:-2] if self.uid.endswith(("_1", "_2", "_3", "_4")) else self.uid
         )
-        self._attr_device_class = DEVICE_CLASSES.get(default_class)
+
+        if device_class := DEVICE_CLASSES.get(default_class):
+            self._attr_device_class = device_class
 
         if default_class in UNITS:
             # by default all sensors with units is measurement sensors

diff --git a/tests/test_entity.py b/tests/test_entity.py
@@ -9,8 +9,9 @@
     COLOR_MODE_RGB,
     LightEntity,
 )
+from homeassistant.components.sensor import SensorDeviceClass, SensorStateClass
 from homeassistant.components.switch import SwitchEntity
-from homeassistant.const import TEMP_FAHRENHEIT
+from homeassistant.const import TEMP_FAHRENHEIT, UnitOfEnergy
 from homeassistant.helpers.device_registry import CONNECTION_NETWORK_MAC
 from homeassistant.util.unit_system import IMPERIAL_SYSTEM
 
@@ -46,6 +47,7 @@
     XEnergySensorDualR3,
     XT5Action,
     XButton91,
+    XEnergyTotal,
 )
 from custom_components.sonoff.switch import (
     XSwitch,
@@ -1654,3 +1656,43 @@ def test_91():
 
     action.internal_update({"op": 2})
     assert action.state == "button_2"
+
+
+def test_powr3():
+    entities = get_entitites(
+        {
+            "extra": {"uiid": 190},
+            "params": {
+                "version": 8,
+                "demNextFetchTime": 1678057200000,
+                "fwVersion": "1.0.7",
+                "current": 0,
+                "voltage": 0,
+                "power": 0,
+                "uiActive": 60,
+                "timeZone": 0,
+                "dayKwh": 7,
+                "monthKwh": 7,
+                "switches": [{"switch": "off", "outlet": 0}],
+                "configure": [{"startup": "off", "outlet": 0}],
+                "pulses": [
+                    {"pulse": "off", "switch": "off", "outlet": 0, "width": 500}
+                ],
+                "rssi": -57,
+                "threshold": {
+                    "actPow": {"min": 10, "max": 400000},
+                    "voltage": {"min": 18500, "max": 26400},
+                    "current": {"min": 10, "max": 1600},
+                },
+                "getHoursKwh": {"start": 4464, "end": 4535},
+                "operSide": 1,
+            },
+        }
+    )
+
+    energy: XEnergyTotal = next(e for e in entities if e.uid == "energy_day")
+    assert energy.device_class == SensorDeviceClass.ENERGY
+    assert energy.unit_of_measurement == UnitOfEnergy.KILO_WATT_HOUR
+    assert energy.state_class == SensorStateClass.TOTAL
+    energy.set_state({"dayKwh": 7})
+    assert energy.native_value == 0.07