Skip to content

ACS-4456 Add reusable workflow for basic Maven build and release #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 6, 2023

Conversation

dsibilio
Copy link
Contributor

@dsibilio dsibilio commented Jan 26, 2023

Adding a reusable workflow to match the most common Travis workflow we have at the moment, which seems to simply be build (sometimes with tests) -> release.

Example of usage: https://github.com/Alfresco/alfresco-tas-ftp-test/actions/runs/4016617042

Note: this is a work in progress, and will be merged only once most if not all repositories that should use such a basic workflow have been tested and therefore the workflow has become at least abstract enough to be utilized properly within all ACS repositories with similar, simple workflows.

damianujma
damianujma previously approved these changes Jan 26, 2023
aonych
aonych previously approved these changes Jan 27, 2023
gionn
gionn previously approved these changes Jan 31, 2023
@dsibilio
Copy link
Contributor Author

dsibilio commented Feb 1, 2023

Added some changes to make the workflow more generic, by allowing the consumer of the workflow to specify if they want the release to be happening automatically or manually induced via [release] commit trigger. Furthermore enabled the consumer to specify the release_branches regex to match all the branches that should be allowed to release the given repository.

Tests I've run with several input permutations:

Test #1 default input: https://github.com/Alfresco/alfresco-tas-email/actions/runs/4065941509/jobs/7001345703
Test #2 [no-release] + auto-release=true: https://github.com/Alfresco/alfresco-tas-email/actions/runs/4065913993/jobs/7001281611
Test #3 wrong release_branches: https://github.com/Alfresco/alfresco-tas-email/actions/runs/4065977169/jobs/7001427598
Test #4 auto-release=false: https://github.com/Alfresco/alfresco-tas-email/actions/runs/4065999192/jobs/7001480858
Test #5 [release] + auto-release=false: https://github.com/Alfresco/alfresco-tas-email/actions/runs/4066014703/jobs/7001513520
Test #6 [release] + auto-release=false + wrong release_branches: https://github.com/Alfresco/alfresco-tas-email/actions/runs/4066035998/jobs/7001565035

damianujma
damianujma previously approved these changes Feb 1, 2023
Copy link
Contributor

@damianujma damianujma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great stuff!

aonych
aonych previously approved these changes Feb 2, 2023
gionn
gionn previously approved these changes Feb 2, 2023
@dsibilio dsibilio merged commit b67398d into master Feb 6, 2023
@dsibilio dsibilio deleted the feature/ACS-4456_migrate-to-GHA branch February 6, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants