Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPSEXP-700: Fix helm related pre-commit checks #5

Merged
merged 22 commits into from
Jan 19, 2021
Merged

OPSEXP-700: Fix helm related pre-commit checks #5

Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
1769acb
Troubleshooting pre-commit command
Jan 12, 2021
8086100
Add verbose to checkov hook
Jan 12, 2021
cd1a2f5
Try wrapping checkov command in single quotes
Jan 12, 2021
83e42d2
Added debugging
Jan 12, 2021
1b7c2cc
Merge branch 'opsexp-700' of github.com:Alfresco/alfresco-build-tools…
Jan 12, 2021
d4e0304
Tweak checkov command
Jan 13, 2021
8a6a6d5
change script back to single line
Jan 13, 2021
ef86356
Use simpler checkov command
Jan 13, 2021
ec28be1
add verbose mode back
Jan 13, 2021
9a302e6
Revert checkov entry cmd
Jan 13, 2021
6020568
Disable caching
Jan 13, 2021
7eab6b0
Remove verbose option from pre-commit command
Jan 14, 2021
b5fd6d5
Re-enable caching for pip and enable verbose mode for pre-commit
Jan 15, 2021
3555354
Update checkov command
Jan 15, 2021
31995b5
Try using separate script
Jan 15, 2021
9e99ab1
Revert script approach
Jan 15, 2021
877651c
Try wrapping in single quotes
Jan 15, 2021
6ffd16f
Wrap all bash commands
Jan 15, 2021
f3a6896
Fix typo
Jan 15, 2021
65c395d
Pass API version directly
Jan 15, 2021
248ed66
Update kubepug commands to use stdin rather than checking running clu…
Jan 15, 2021
a6d5786
Revert the changes to caching behaviour
Jan 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .pre-commit-hooks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,38 +5,38 @@
files: \.travis.*\.y(a?)ml$
- id: helm-deps
name: Helm Dependency Update
entry: bash -c 'find . -name Chart.yaml' | xargs -n1 -I% bash -c "dirname %" | xargs -t -n1 -I% helm dep up %
entry: bash -c 'find . -name Chart.yaml | xargs -n1 -I% bash -c "dirname %" | xargs -t -n1 -I% helm dep up %'
language: system
pass_filenames: false
- id: helm-lint
name: Helm Lint
entry: bash -c "find . -name Chart.yaml" | xargs -n1 -I% bash -c "dirname %" | xargs -t -n1 -I% helm lint %
entry: bash -c 'find . -name Chart.yaml | xargs -n1 -I% bash -c "dirname %" | xargs -t -n1 -I% helm lint %'
language: system
pass_filenames: false
- id: kubepug-minimum
name: KubePug - k8s v1.15 minimum
entry: bash -c "find . -name Chart.yaml" | xargs -n1 -I% bash -c "dirname %" | xargs -t -n1 -I% env K8S_TARGET_VERSION=v1.15.0 bash -c 'helm template % --api-versions $K8S_TARGET_VERSION | kubepug --error-on-deleted --k8s-version $K8S_TARGET_VERSION'
entry: bash -c 'find . -name Chart.yaml | xargs -n1 -I% bash -c "dirname %" | xargs -t -n1 -I% bash -c "helm template % --api-versions v1.15.0 | kubepug --error-on-deprecated --error-on-deleted --k8s-version v1.15.0 --input-file /dev/stdin"'
language: system
pass_filenames: false
- id: kubepug-recommended
name: KubePug - k8s v1.18 recommended
entry: bash -c "find . -name Chart.yaml" | xargs -n1 -I% bash -c "dirname %" | xargs -t -n1 -I% env K8S_TARGET_VERSION=v1.18.0 bash -c 'helm template % --api-versions $K8S_TARGET_VERSION | kubepug --error-on-deleted --k8s-version $K8S_TARGET_VERSION'
entry: bash -c 'find . -name Chart.yaml | xargs -n1 -I% bash -c "dirname %" | xargs -t -n1 -I% bash -c "helm template % --api-versions v1.18.0 | kubepug --error-on-deprecated --error-on-deleted --k8s-version v1.18.0 --input-file /dev/stdin"'
language: system
pass_filenames: false
- id: kubepug-latest
name: KubePug - k8s latest
entry: bash -c "find . -name Chart.yaml" | xargs -n1 -I% bash -c "dirname %" | xargs -t -n1 -I% bash -c "helm template % | kubepug --error-on-deleted" || true # allowed to fail
entry: bash -c 'find . -name Chart.yaml | xargs -n1 -I% bash -c "dirname %" | xargs -t -n1 -I% bash -c "helm template % | kubepug --error-on-deprecated --error-on-deleted --input-file /dev/stdin"'
language: system
pass_filenames: false
- id: plantuml-svg
name: PlantUML SVG converter
entry: bash -c "for FILE in $@; do cat $FILE | docker run --rm -i think/plantuml > ${FILE%.*}.svg; done"
entry: bash -c 'for FILE in $@; do cat $FILE | docker run --rm -i think/plantuml > ${FILE%.*}.svg; done'
language: system
types: [file]
files: \.puml$
- id: plantuml-png
name: PlantUML PNG converter
entry: bash -c "for FILE in $@; do cat $FILE | docker run --rm -i think/plantuml -tpng > ${FILE%.*}.png; done"
entry: bash -c 'for FILE in $@; do cat $FILE | docker run --rm -i think/plantuml -tpng > ${FILE%.*}.png; done'
language: system
types: [file]
files: \.puml$
Expand All @@ -49,6 +49,6 @@
pass_filenames: false
- id: checkov-helm
name: Checkov - Helm check
entry: bash -c "find . -name Chart.yaml" | xargs -n1 -I% bash -c "dirname %" | xargs -t -n1 -I% bash -c "helm template % > %.yaml && checkov -f %.yaml --framework kubernetes" || true # allowed to fail
entry: bash -c 'find . -name Chart.yaml | xargs -n1 -I% bash -c "dirname %" | xargs -t -n1 -I% bash -c "helm template % > %.yaml && checkov -f %.yaml --framework kubernetes"'
language: system
pass_filenames: false