Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MNT-21968 catch NumberFormatException on parseInt #192

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Fix MNT-21968 catch NumberFormatException on parseInt #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc47b35
Fix MNT-21968 catch NumberFormatException on parseInt
nbarithel Dec 2, 2020
6be6576
Fix MNT-21968 test case "v00Draft.pdf"
nbarithel Dec 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion repository/src/main/java/org/alfresco/repo/virtual/ref/ZeroReferenceParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ else if ((protocolResourceEncoding - NODE_PROTOCOL_CODE) < VIRTUAL_PROTOCOL_CODE
parameters);
return reference;
}
catch (ArrayIndexOutOfBoundsException e)
catch (ArrayIndexOutOfBoundsException | NumberFormatException e)
{
throw new ReferenceParseException("Invalid reference",
e);
Expand Down
3 changes: 3 additions & 0 deletions repository/src/test/java/org/alfresco/repo/virtual/store/VirtualStoreImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,9 @@ public void testCanExistNodeIDwithV()
// vp...
createAndCheckNodeId("v"+Encodings.PLAIN.encoding.token+"file", "specialFile5.txt");

// MNT-21968
createAndCheckNodeId("v"+Encodings.ZERO.encoding.token+"0Draft.pdf", "specialFile6.txt");

NodeRef virtualFolder = createVirtualizedFolder(testRootFolder.getNodeRef(), VIRTUAL_FOLDER_3_NAME, TEST_TEMPLATE_4_JSON_SYS_PATH);

assertTrue(smartStore.canVirtualize(virtualFolder));
Expand Down