ACS-6653 Bump Tika, POI, bouncycastle, commons-compress, xmlbeans #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsibilio
commented
Jan 31, 2024
Comment on lines
218
to
219
| </dependency> | ||
| <dependency> | ||
| <groupId>org.bouncycastle</groupId> | ||
| <artifactId>bcmail-jdk15to18</artifactId> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
Removed because we don't exclude bcmail from tika-parsers-standard-package anymore so we don't need to re-declare this anymore IMO.
dsibilio
commented
Jan 31, 2024
| <dependency.truezip.version>7.7.10</dependency.truezip.version> | ||
| <dependency.poi.version>5.2.2</dependency.poi.version> | ||
| <dependency.poi-ooxml-lite.version>5.2.3</dependency.poi-ooxml-lite.version> | ||
| <dependency.poi.version>5.2.5</dependency.poi.version> |
There was a problem hiding this comment.
Removed poi-ooxml-lite.version property as it should always match the poi version anyways.
dsibilio
commented
Jan 31, 2024
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.poi</groupId> | ||
| <artifactId>poi-ooxml-lite</artifactId> |
There was a problem hiding this comment.
poi-ooxml-lite is already a transitive dependency of poi-ooxml, no need to redeclare it.
dsibilio
commented
Jan 31, 2024
| <exclusions> | ||
| <exclusion> | ||
| <groupId>org.apache.poi</groupId> | ||
| <artifactId>poi-ooxml-schemas</artifactId> |
There was a problem hiding this comment.
This transitive dependency is not even really there so I'm not sure why the exclude was here, probably by mistake.
dsibilio
requested review from
aonych,
tpage-alfresco,
mikolajbrzezinski,
kcichonczyk,
damianujma and
wojtekswieton
aonych
approved these changes
Jan 31, 2024
mikolajbrzezinski
approved these changes
Jan 31, 2024
tpage-alfresco
approved these changes
Feb 1, 2024
This was referenced Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping a bunch of intertwined/related dependencies together to make sure everything works as intended.
Propagation tests:
Related PRs:
maven-enforcer-pluginrequirements)