OPSEXP-2242: remove usage of lookup in alfresco-repository #105
Conversation
alxgomz
changed the title
alxgomz
changed the title
| @@ -233,3 +239,7 @@ global: | |||
| alfrescoRegistryPullSecrets: quay-registry-secret | |||
| # -- a fallback for .Values.known_urls that can be shared between charts | |||
| known_urls: | |||
|
|
|||
| # @ignore | |||
There was a problem hiding this comment.
it is not better to document the purpose of this? users are going to discover it anyway by looking at values
There was a problem hiding this comment.
I think it would just be "doc pollution" as no one is ever supposed to use that. If we end up introducing something valuable to users as tags then we would document it
There was a problem hiding this comment.
users are not supposed to use that but I see a value telling them explicitly "this is just for testing the chart - don't use it"
| keys: | ||
| # -- Key within the secret holding the message broker username | ||
| username: BROKER_USERNAME | ||
| # -- Key within the secret holding the message broker password | ||
| password: BROKER_PASSWORD | ||
| existingConfigMap: | ||
| # -- Name of a pre-existing configmap containing the meesage broker URL | ||
| name: null | ||
| name: "" |
There was a problem hiding this comment.
This is needed by the tpl() function which expects a string and breaks in case of a null object instead. But as I write this I think it would be better to cast the value when using the function to make the whole thing more robust... wdyt?
There was a problem hiding this comment.
well if it's just for that it's better to handle that specific case there and do not pollute values with empty strings instead of plain nulls
There was a problem hiding this comment.
reverted the whole tpl thing for now
Ref: OPSEXP-2242
Reverting as unusable when called from a parent chart