MNT-20337/REPO-4534/ATS-484 LibreOffice 6.1.6 #78
Conversation
README.md
Outdated
| @@ -16,7 +16,7 @@ Contains the common transformer (T-Engine) code, plus a few actual implementatio | |||
|
|
|||
| The project can be built by running the Maven command: | |||
| ```bash | |||
| mvn clean install -Plocal | |||
| mvn clean install -DskipTests -Plocal | |||
There was a problem hiding this comment.
Requires ActiveMQ to be running and configured at the moment, so you might like to work out what needs to change in the README.md, before closing ATS-484.
There was a problem hiding this comment.
Yes, we should update the README steps (as needed) so that we do not skip tests when building locally. It might be as a separate PR.
There was a problem hiding this comment.
I've updated the line with the proper profiles.
| @@ -18,8 +18,8 @@ COPY target/alfresco-docker-libreoffice-${env.project_version}.jar libreoffice-d | |||
|
|
|||
| RUN ln /alfresco-docker-libreoffice-${env.project_version}.jar /usr/bin/alfresco-docker-libreoffice.jar && \ | |||
| yum install -y cairo cups-libs libSM && \ | |||
| test -f libreoffice-dist-5.4.6-linux.gz && \ | |||
| ln -s libreoffice-dist-5.4.6-linux.gz libreoffice-dist-linux.gz || \ | |||
| test -f libreoffice-dist-6.1.6-linux.gz && \ | |||
There was a problem hiding this comment.
If I owned this code I would not have the version number in the code. Currently it needs to be updated in 3 places in this file and also in the executor (if the minor version changes).
There was a problem hiding this comment.
Done. I've added Dockerfile arguments for the LibreOffice & ImageMagick versions.
|
Yes, of course - all tested contributions are gratefully accepted :-) Do we know if the unit tests (in this project &/or Repo are sufficient to catch blatant regressions ? |
|
I've merged the We'll most likely merge this PR once we run a few minor sanity tests. |
Can I have your 3 story points for ATS-484 :) Needed to work out if 6.1.6 was compatible with alfresco-jodconverter-core-3.0.1.1 which is used by both the Libreoffice T-Engine and the repo.