30 use auto formatter for code style #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quests in a queue pair), not just relying on device information about max_qp_wr, but actually trying to create QPs via ibv_create_qp with different max_send_wr until we find the largest still working number (via binary search). This becomes the updated m_maxSrs. Independently, the 100K element test manyPuts needs to be downgraded to 5K for our cluster, as our count is just over 10K, but actually 10K does not work as well (not sure why?)
…e in manyPuts -- the device does not support having too many messages in the send WR QP
…it is very complicated to fix these tests - they seem all over the place, not working, but commiting it
… (only the minimum) but still have many failing tests without explanation, and not tested at all properly
…in the execute command. Also, reduce some example message count as it does not work with IB Verbs with very large tests on the ARM machine
…ted with the debug subdirectory
…ent logic if the bloody Gtest wants to just list the tests or run them
…ATH, and that should be it
…. Also, using Setup and TearDown for entire test suite now, pretty neat, no code duplication each time
…d remove c99 requirement and turn them into C++ tests
… I need to make MPI engines in debug layer call MPI_Abort, and pthread engine in debug layer call std::abort
…y, while it works, this didn't solve the problem. Mpirun still is used with pthreads, so it changes the std::abort signal to 134. This is why now I changed the launcher. Still having issues with some hybrid tests though.
… actually contaminating the hybrid code
…ap script from pre-existing googletest messages
… which internally is non-portably converted to 134. This also simplifies the launcher script. Also fix some incorrect delete's for arrays in the collectives
…y, we get all tests at the moment via gtest_add_tests. It would be good to replace gtest_add_tests with gtest_discover_tests in the future though, because the current one takes 60-90 seconds to configure. Also, there is a horrible bug now where if I specify a high CMake version (e.g. the needed 3.29.0), the GoogleTests would simply not compile at all
… decrease in manyPuts -- the device does not support having too many messages in the send WR QP" This reverts commit 219372a.
… send requests in a queue pair), not just relying on device information about max_qp_wr, but actually trying to create QPs via ibv_create_qp with different max_send_wr until we find the largest still working number (via binary search). This becomes the updated m_maxSrs. Independently, the 100K element test manyPuts needs to be downgraded to 5K for our cluster, as our count is just over 10K, but actually 10K does not work as well (not sure why?)" This reverts commit 1136a2b.
…est fixing changes
…ompiler in README
…MPICH and Open MPI tests. However, in the current setting, Open MPI cannot successfully run dynamichook (missing ompi-server daemon, missing argument for ompi-server network endpoint for the processes). Therefore, now there is a check if Open MPI (of any version) is used -- cmake/is_openmpi.c. If it passes, dynamichook is not built.
…t the max message size, so that it can make an educated choice on a very large message that needs fragmentation. The previous test was just blindly guessing, which is bad. Also, make sure you register and deregister slots for each test, and all tests are only once set up and torn down now.
… processes which grep each file multiple times, but internal regex for strings populated from files. Also, replace again gtest_add_tests with gtest_discover_tests, and make it work by fixing a bug in the test launcher which was capturing output
…running the binary leads to terminaton as Open MPI cannot figure how many processes to use from Slurm. So I always need to launch via parallel launcher
…If run without proper arguments it fails (expected code 1), but if it is run with the custom script dynamic.t.sh for a number of custom test cases, it should run with the proper 5 arguments and pass. Note this test only runs with MPICH at the moment.
…ter some debugging, it seems to happen in a free call with an error message about corrupted chunks. It seems like it happens at destruction of some threads. I believe me replacing abort with exit has lead to that. Based on online documentation, exit calls destructors, and abort does not. As a workaround, I now use quick_exit - I can still pass the exit code, but no destructors are called, and the erros seems to disappear
… not expose lpf_debug in the API, but only internally expose lpf_debug_abort in each engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #30