Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3D Differential Operators #60

Merged
merged 25 commits into from
Jun 14, 2024
Merged

3D Differential Operators #60

merged 25 commits into from
Jun 14, 2024

Conversation

lukem12345
Copy link
Member

@lukem12345 lukem12345 commented Aug 15, 2023 •
edited
Loading

This pull request adds support for 3D differential operators via a "DeltaDualComplex" strategy that is analogous to the 1D and 2D cases.

Before merging:

  • Implement wedge product of 1-forms and 2-forms
  • Implement flat and sharp by dispatching on dimension of the DeltaDualComplex
  • Increase code coverage

lukem12345 and others added 21 commits June 29, 2023 15:44
@lukem12345
Implement 3D simplicial sets
7093de4
@lukem12345
Return tet edges and test tet cube volume
ba690b6
@lukem12345
Add manifold-like test for delta sets
f2fc94e
@lukem12345
Add tetrahedra cube from literature
b85330e
@lukem12345
Add Letniowski mesh test
f990111
@lukem12345
Rename nonfaces to nonboundaries and simplify
d1385c5
@lukem12345
Add stub for triangles accessor using axioms
01e351c
@lukem12345
Clean tests, todos, and triangles return types
567f68d
@lukem12345
Add subdivision migrs, flat matrix, star, and link
1a83d0b
@lukem12345
Dispatch on DVF multiplication to auto-reinterpret
166d7b2
@lukem12345
Remove redundant re-indexing of triangle centers
50dbbe6
@lukem12345
Implement sharp matrix and Desbrun sharp
635d68f
@lukem12345
Condense sharp tests
6264063
@lukem12345
Reorganize and test 1D data-mig subdivision
75de354
@lukem12345
Fix factorial in wedge product with 0-forms
87da8ea
@lukem12345
Add 3D dual complex schema
3903bdc
@lukem12345
Subdivide tetrahedra
9b1da83
@lukem12345
Test primal-dual tet accessors
66589ad
@lukem12345
Clean tet subdiv and test elementary duals
730cfbf
@lukem12345
Orient dual tets and create dual (co)boundary ops
49e1c78
@lukem12345
Compute dual volumes
1848dcc
@lukem12345 lukem12345 self-assigned this Aug 15, 2023
@lukem12345 lukem12345 marked this pull request as ready for review April 26, 2024 20:11
@lukem12345 lukem12345 requested a review from GeorgeR227 April 26, 2024 20:11
@lukem12345
Copy link
Member Author

On merging, I will open an issue to implement the 1-2 wedge.

GeorgeR227
GeorgeR227 requested changes Jun 13, 2024
View reviewed changes
src/DiscreteExteriorCalculus.jl Outdated Show resolved Hide resolved
src/DiscreteExteriorCalculus.jl Show resolved Hide resolved
src/DiscreteExteriorCalculus.jl Show resolved Hide resolved
src/DiscreteExteriorCalculus.jl Show resolved Hide resolved
test/DiscreteExteriorCalculus.jl Show resolved Hide resolved
@lukem12345 lukem12345 merged commit 4a080fb into main Jun 14, 2024
6 of 7 checks passed
@lukem12345 lukem12345 mentioned this pull request Jun 14, 2024
Closed
2 tasks
KevinDCarlson pushed a commit that referenced this pull request Jul 24, 2024
@lukem12345
3D Differential Operators (#60)
76094d1
KevinDCarlson pushed a commit that referenced this pull request Sep 25, 2024
@lukem12345 @KevinDCarlson
3D Differential Operators (#60)
deea1ef
KevinDCarlson pushed a commit that referenced this pull request Sep 25, 2024
@lukem12345 @KevinDCarlson
3D Differential Operators (#60)
03ff0c7
KevinDCarlson pushed a commit that referenced this pull request Sep 25, 2024
@lukem12345 @KevinDCarlson
3D Differential Operators (#60)
8f8cc5c
KevinDCarlson pushed a commit that referenced this pull request Sep 25, 2024
@lukem12345 @KevinDCarlson
3D Differential Operators (#60)
2dac4a9
KevinDCarlson pushed a commit that referenced this pull request Sep 25, 2024
@lukem12345 @KevinDCarlson
3D Differential Operators (#60)
24b6caf
KevinDCarlson pushed a commit that referenced this pull request Oct 10, 2024
@lukem12345 @KevinDCarlson
3D Differential Operators (#60)
b52d254
KevinDCarlson pushed a commit that referenced this pull request Oct 10, 2024
@lukem12345 @KevinDCarlson
3D Differential Operators (#60)
bfed80c
KevinDCarlson pushed a commit that referenced this pull request Oct 18, 2024
@lukem12345 @KevinDCarlson
3D Differential Operators (#60)
dc729c9
KevinDCarlson pushed a commit that referenced this pull request Oct 18, 2024
@lukem12345 @KevinDCarlson
3D Differential Operators (#60)
581670d
KevinDCarlson pushed a commit that referenced this pull request Oct 24, 2024
@lukem12345 @KevinDCarlson
3D Differential Operators (#60)
4512234
KevinDCarlson pushed a commit that referenced this pull request Oct 24, 2024
@lukem12345 @KevinDCarlson
3D Differential Operators (#60)
becd0e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeR227 GeorgeR227 GeorgeR227 requested changes

Assignees

@lukem12345 lukem12345

Labels
physics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukem12345 @GeorgeR227