Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlgDot and AlgStruct fields use symbols #140

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kris-brown
Copy link
Collaborator

Addresses #138

Perhaps due to julia version bump, some unrelated tests in MetaUtils stopped passing (looks like Julia is better at grabbing LineNumberNodes) so those tests were slightly changed to strip more LineNumberNodes before comparing equality.

@kris-brown kris-brown self-assigned this Feb 16, 2024
@kris-brown kris-brown requested a review from olynch February 16, 2024 21:16
@kris-brown kris-brown added the enhancement New feature or request label Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1ee1536) 96.61% compared to head (e1ea961) 96.66%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   96.61%   96.66%   +0.04%     
==========================================
  Files          38       38              
  Lines        2067     2067              
==========================================
+ Hits         1997     1998       +1     
+ Misses         70       69       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant