-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feet dsl update #88
Closed
Closed
Feet dsl update #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssv, etc to StockFlow.jl, several methods to Syntax.jl (incl infer_links, which is now exported), and a Stratification.jl file. Also created a Stratification tests file and added more tests to Syntax.
…v, etc. getter methods
…ch are unmapped. Was previously two separate loops.
…ssary variables. Additional type annotations.
… and replaced a few sfstratify calls in the test file with the macro call.
… end block. Minor docstring updates.
…ant information. Contains dictionaries and vectors which are updated as it goes along. Created macro n_stratify, which generalizes stratify and can take an arbitrary number of stockflows as arguments. Still needs tests. Updated tests to reflect changes in stratification functions.
… System Structure so instead of folding right, it checks all vops are equal (line 195)
removed testing code
…ally make sense to take the pullback of 0 items so removed that as an option. Now allow single symbols to be interpreted as a tuple with one element, so n_stratify is far less cumbersome to write for.
…pty vector of StockAndFlow0
Note, I merged nstratify here, then updated. |
...wrong branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@feet without arguments returns an empty Vector{StockAndFlow0}. Fixed feet and foot so they return errors, as opposed to causing an error in the preprocessing stage of replacing with macro.