Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated builds #6

Merged
merged 4 commits into from
Sep 23, 2018
Merged

Automated builds #6

merged 4 commits into from
Sep 23, 2018

Conversation

austinpray
Copy link
Contributor

@austinpray austinpray commented Sep 23, 2018

  • Simplifies the dockerfile (using an image I maintain lol)
  • Basic e2e test
  • Automated builds using travis

If you set up travis properly and set up your hub.docker.com account people will now be able to do docker run -d -p 3000:3000 algram/ytdl-webserver without cloning this repo first. You can also set up daily cron jobs on travis to keep youtube-dl up-to-date on the image https://docs.travis-ci.com/user/cron-jobs/

You need the following env vars in travis https://docs.travis-ci.com/user/environment-variables/#defining-variables-in-repository-settings

  • DOCKER_TAG = algram/ytdl-webserver
  • DOCKER_USERNAME = algram but it depends on what you set up at hub.docker.com
  • DOCKER_PASSWORD = whatever password for hub.docker.com

You can try it yourself https://hub.docker.com/r/austinpray/ytdl-webserver/

docker run -d -p 3000:3000 austinpray/ytdl-webserver

@cascha42
Copy link

hey, thank you. the docker container stays not up:
error:

docker@test:~ $ docker run -d -p 3000:3000 austinpray/ytdl-webserver
8d4351df1d32187a5fac50de5f05fca1b1bf79bab66589aecf987903348b4241                                                                                                                                                     
docker@test:~ $ docker logs 8d4351df1d32187a5fac50de5f05fca1b1bf79bab66589aecf987903348b4241                                                                                                                  
standard_init_linux.go:190: exec user process caused "exec format error"

thank you

@Algram
Copy link
Owner

Algram commented Sep 23, 2018

Perfect, I will set up the Accounts and travis-ci today!

@cascha42
Copy link

awesome, thank you!

@mauritsvdvijgh
Copy link

Made a PR on top of the current state of this one (not sure what the best way to handle that is). It adds a small run only webapp build which is lighter than this one. Which makes sense imho if you add automatic builds and running without cloning the repo/building the image.

@Algram
Copy link
Owner

Algram commented Sep 23, 2018

I will not merge the Dockerfile changes in this PR right now since I'd like for us to try the Alpine approach @mauritsvdvijgh mentioned. I will merge the CI stuff though, thanks a ton!

@Algram Algram merged commit 7782ce3 into Algram:master Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants