Swift 4.2 support (#58)

* Add support for Swift 4.2 (keep compatible with older versions)

* Changelog entry

* Ensure the example code compiles in Swift 4.2

* Address SwiftLint warnings

* Migrate tvOS Target to 4.2 too

* Fix compilation issue with NSLayoutConstraint.Attribute

* addConstraint is deprecated ==> NSLayoutConstraint.activate

* Update to Xcode 10 recommended settings

* Fix SwiftLint violations.

.swiftlint.yml

@@ -1,5 +1,2 @@
-disabled_rules:
-  - missing_docs
-
 line_length:
   warning: 120

CHANGELOG.md

@@ -1,10 +1,16 @@
 # CHANGELOG
 
+## Master
+
+* Update project to support Swift 4.2.  
+  [djbe](https://github.com/djbe)
+  [#58](https://github.com/AliSoftware/Reusable/pull/58)
+
 ## 4.0.2
 
 * Update project to support Swift 4.  
   [@AYastrebov](https://github.com/AYastrebov)
-  [#42](https://github.com/AliSoftware/Reusable/pull/54)
+  [#54](https://github.com/AliSoftware/Reusable/pull/54)
 
 * Fix typo in StoryboardBased examples.  
   [@danshevluk](https://github.com/danshevluk)

Example/.swiftlint.yml

@@ -1,12 +1,11 @@
 opt_in_rules:
   - empty_count
-  - missing_docs
 
 included:
   - ../Sources
   - ReusableDemo
 
 line_length:
-  warning: 160
-  error: 200
+  warning: 120
+  error: 160
 

Example/ReusableDemo iOS/AppDelegate.swift

@@ -14,8 +14,15 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
   var window: UIWindow?
 
   func application(_ application: UIApplication,
-                   didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool {
+                   didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
     // Override point for customization after application launch.
     return true
   }
 }
+
+/// Swift < 4.2 support
+#if !(swift(>=4.2))
+extension UIApplication {
+  typealias LaunchOptionsKey = UIApplicationLaunchOptionsKey
+}
+#endif

Example/ReusableDemo iOS/CollectionViewController.swift

@@ -21,7 +21,7 @@ final class CollectionViewController: UICollectionViewController {
     //    self.collectionView.registerReusableCell(MyStoryBoardIndexPathCell)
 
     collectionView.register(supplementaryViewType: CollectionHeaderView.self,
-                            ofKind: UICollectionElementKindSectionHeader)
+                            ofKind: UICollectionView.elementKindSectionHeader)
 
     if let flowLayout = self.collectionView?.collectionViewLayout as? UICollectionViewFlowLayout {
       flowLayout.headerReferenceSize = CGSize(width: collectionView.bounds.size.width, height: 60)
@@ -67,3 +67,10 @@ final class CollectionViewController: UICollectionViewController {
       }
   }
 }
+
+/// Swift < 4.2 support
+#if !(swift(>=4.2))
+private extension UICollectionView {
+  static let elementKindSectionHeader = UICollectionElementKindSectionHeader
+}
+#endif

Example/ReusableDemo iOS/TableViewController.swift

@@ -27,7 +27,12 @@ final class TableViewController: UITableViewController {
   }
 
   override func tableView(_ tableView: UITableView, viewForHeaderInSection section: Int) -> UIView? {
-    let frame = CGRect(x: 0, y: 0, width: tableView.bounds.size.width, height: self.tableView(tableView, heightForHeaderInSection: section))
+    let frame = CGRect(
+      x: 0,
+      y: 0,
+      width: tableView.bounds.size.width,
+      height: self.tableView(tableView, heightForHeaderInSection: section)
+    )
     // See the overridden `MyHeaderTableView.init(frame:)` initializer, which
     // automatically loads the view content from its nib using loadNibContent()
     let view = MyHeaderTableView(frame: frame)

Example/ReusableDemo tvOS/AppDelegate.swift

@@ -13,9 +13,16 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
 
   var window: UIWindow?
 
-  func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool {
+  func application(_ application: UIApplication,
+                   didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
     // Override point for customization after application launch.
     return true
   }
+}
 
+/// Swift < 4.2 support
+#if !(swift(>=4.2))
+extension UIApplication {
+  typealias LaunchOptionsKey = UIApplicationLaunchOptionsKey
 }
+#endif