Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only allowing extension api #70

Merged
merged 3 commits into from
Oct 13, 2018
Merged

Only allowing extension api #70

merged 3 commits into from
Oct 13, 2018

Conversation

igorkulman
Copy link
Contributor

Fixes #69

@AliSoftware
Copy link
Owner

Cool! Thanks a lot for taking the time to do the PR!

Could you just add an entry in the CHANGELOG.md to mention that change and credit yourself? Thanks!

@AliSoftware
Copy link
Owner

Sorry, I should have mentioned in my previous comment: the new entry shouldn't go under ## 4.0.3 — which is already released — but under a new entry that I usually call ## Master to list fixes not yet released (I then change that ## Master entry to ## 4.0.4 or ## 4.1.0 or what's the next version will be when I actually do the release of the next version)

@igorkulman
Copy link
Contributor Author

No problem, fixed.

@AliSoftware
Copy link
Owner

This seems perfect 👌 thanks a lot! 🙌

@AliSoftware AliSoftware merged commit b4c0a8f into AliSoftware:master Oct 13, 2018
@AliSoftware
Copy link
Owner

Reusable 4.0.4 has just been released to include your fix (I finally decided to do a release right away after your fix) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliSoftware AliSoftware AliSoftware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorkulman @AliSoftware