Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning when use library in App Extension as framework #88

Closed
wants to merge 1 commit into from

Conversation

nahung89
Copy link

@nahung89 nahung89 commented Sep 3, 2019

I'm using Reusable with Carthage, and there is a warning appears:

linking against a dylib which is not safe for use in application extensions

Follow to this answer, I can be able to fix the warning.

Hope this can help other people who has the same issue with me.

Thank you for making a useful library!

AliSoftware pushed a commit that referenced this pull request Oct 23, 2019
In order for users installing it via Carthage to be able to use Reusable in App Extensions too
See #88@nahung89
AliSoftware pushed a commit that referenced this pull request Oct 23, 2019
In order for users installing it via Carthage to be able to use Reusable in App Extensions too
See #88@nahung89
AliSoftware pushed a commit that referenced this pull request Oct 23, 2019
In order for users installing it via Carthage to be able to use Reusable in App Extensions too
See #88@nahung89
AliSoftware pushed a commit that referenced this pull request Oct 23, 2019
In order for users installing it via Carthage to be able to use Reusable in App Extensions too
See #88@nahung89
@AliSoftware
Copy link
Owner

Hi @nahung89 !

Thanks a lot for your PR and so sorry for not getting back to you sooner.

The changes you've made here are manual changes to a generated file (Pods.xcodeproj is generated by CocoaPods) so they would have been overwritten by any new update of Reusable and any release of Reusable to CocoaPods that I'd have made in the future.

So instead I update the Podfile used by CococaPods to generate those projects to auto-set APPLICATION_EXTENSION_API_ONLY=YES when generating the projects – and thus the targets generating the framework that Carthage ends up using.

You can see my PR #98 for the changes. I'll merge it tonight and plan to make a new release of the lib soon after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants