Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SPM support #89

Merged
merged 1 commit into from
Oct 6, 2019
Merged

Fix SPM support #89

merged 1 commit into from
Oct 6, 2019

Conversation

M0rtyMerr
Copy link
Contributor

Current Package.swift was broken, so I fixed it

@guillaumealgis
Copy link

While I'm not a huge fan of hiding all the UIKit code from SwiftPM to make it accept the package, I don't see any other way right now.
Until SwiftPM implements platform restrictions for packages (and that's probably not coming soon, I could not find any discussion on this topic) I'd say let's roll with that.

So +1, clever trick and seems to work well, thank you @MortyMerr !
I'd love to see this PR merged ☺️

Copy link
Owner

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR 👍
I'm gonna merge this as it as it's usable but I wonder if in a subsequent PR it would make sense to add some #error "This library only supports UIKit" in the #else branch 🤔 😉

@AliSoftware AliSoftware merged commit 80778cf into AliSoftware:master Oct 6, 2019
@M0rtyMerr
Copy link
Contributor Author

I guess it should be obvious from library description)

Sent with GitHawk

@M0rtyMerr
Copy link
Contributor Author

Thanks a lot for attention

Sent with GitHawk

@guillaumealgis
Copy link

I'm gonna merge this as it as it's usable but I wonder if in a subsequent PR it would make sense to add some #error "This library only supports UIKit" in the #else branch 🤔 😉

@AliSoftware Haven't tested it, but I suppose it would defeat the purpose of this PR as SPM would choke on the #error when trying to compile the package (it seems Xcode's SPM integration tries to compile the dependencies with macOS as the target, hence the UIKit error).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants