-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix][Refactor] Fix some bugs and refine codes for large scale simulator test #93
Open
s5u13b
wants to merge
55
commits into
main
Choose a base branch
from
request_timestamps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,115
−912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
s5u13b
commented
Jan 16, 2025
•
edited
Loading
edited
- Simplify request timestamps implementation and add metrics
- Set max-instances for auto_scale_up loop
- Support retry binding address for zmq server
- Support power-of-k-choice for dispatch
- Change num_cpus of ProxyActor from 1 to 0
- Fix some bugs: abort in AsyncStream, host in glocal launch mode, simulator in global launch mode
- Reorg simulator files
- Reorg global_scheduler directory
- Resort manager and launcher functions
- Others Minors
s5u13b
changed the title
[Observability] Refine request timestamps implementation and add more metrics
[WIP][Observability] Refine request timestamps implementation and add more metrics
Jan 16, 2025
|
|
s5u13b
changed the title
[WIP][Observability] Refine request timestamps implementation and add more metrics
[Observability] Refine request timestamps implementation and add more metrics
Jan 17, 2025
s5u13b
force-pushed
the
request_timestamps
branch
from
January 20, 2025 04:27
5501476
to
8ec7ba7
Compare
|
|
|
|
|
|
|
|
|
|
s5u13b
changed the title
[Observability] Refine request timestamps implementation and add more metrics
[Observability] Refine request timestamps implementation and add more metrics & Reorg simulator files
Jan 21, 2025
|
|
s5u13b
changed the title
[Observability] Refine request timestamps implementation and add more metrics & Reorg simulator files
[Observability] Refine request timestamps implementation and add more metrics
Jan 22, 2025
|
|
s5u13b
force-pushed
the
request_timestamps
branch
from
February 7, 2025 11:38
1a49a08
to
d2894ca
Compare
|
|
commit 48c674b Author: s5u13b <sunbiao.sun@alibaba-inc.com> Date: Fri Feb 7 09:41:05 2025 +0000 Fix lint commit 322862b Author: s5u13b <sunbiao.sun@alibaba-inc.com> Date: Fri Feb 7 09:39:31 2025 +0000 Fix entrypoints unit test commit 75af824 Author: s5u13b <sunbiao.sun@alibaba-inc.com> Date: Fri Feb 7 08:07:26 2025 +0000 Fix lint commit 2818c8d Author: s5u13b <sunbiao.sun@alibaba-inc.com> Date: Fri Feb 7 08:06:08 2025 +0000 Fix cr commit a172468 Author: s5u13b <sunbiao.sun@alibaba-inc.com> Date: Fri Feb 7 07:01:07 2025 +0000 Fix lint commit 3f863b2 Author: s5u13b <sunbiao.sun@alibaba-inc.com> Date: Fri Feb 7 06:54:18 2025 +0000 Add back timestamp commit 2e53b24 Author: s5u13b <sunbiao.sun@alibaba-inc.com> Date: Fri Feb 7 06:45:16 2025 +0000 Fix lint commit eea1a3a Author: s5u13b <sunbiao.sun@alibaba-inc.com> Date: Fri Feb 7 06:37:30 2025 +0000 Add back timestamps commit b4a45ef Author: s5u13b <sunbiao.sun@alibaba-inc.com> Date: Fri Feb 7 06:21:48 2025 +0000 Remove old filter commit f2df197 Author: s5u13b <sunbiao.sun@alibaba-inc.com> Date: Fri Feb 7 06:12:53 2025 +0000 Add _process_model_outputs back commit a51cf25 Author: s5u13b <sunbiao.sun@alibaba-inc.com> Date: Fri Feb 7 03:46:45 2025 +0000 Fix abort commit 1058ec0 Author: s5u13b <sunbiao.sun@alibaba-inc.com> Date: Fri Feb 7 02:43:14 2025 +0000 Remove blank todo commit 670018e Author: s5u13b <sunbiao.sun@alibaba-inc.com> Date: Fri Feb 7 02:36:27 2025 +0000 Filter out migrating request commit fa2fc9c Author: s5u13b <sunbiao.sun@alibaba-inc.com> Date: Fri Jan 24 06:25:35 2025 +0000 Remove process_model_outputs request timestamps commit 2a980ca Author: s5u13b <sunbiao.sun@alibaba-inc.com> Date: Fri Jan 24 06:10:49 2025 +0000 Fix linting commit 78a1ab4 Author: s5u13b <sunbiao.sun@alibaba-inc.com> Date: Fri Jan 24 05:30:15 2025 +0000 Fix request leaking bug of migration commit 774205b Author: s5u13b <sunbiao.sun@alibaba-inc.com> Date: Fri Jan 24 03:11:08 2025 +0000 Fix commit 814521e Author: s5u13b <sunbiao.sun@alibaba-inc.com> Date: Fri Jan 24 02:57:20 2025 +0000 Minors commit b3f0688 Author: s5u13b <sunbiao.sun@alibaba-inc.com> Date: Fri Jan 24 01:56:09 2025 +0000 Change ci timeout-minutes
s5u13b
force-pushed
the
request_timestamps
branch
from
February 12, 2025 07:57
00d3273
to
2c4cc50
Compare
s5u13b
changed the title
[Observability] Refine request timestamps implementation and add more metrics
[Observability][GlobalScheduler][BugFix] Simplify request timestamps implementation & Support power-of-k-choice for dispatch & Fix some bugs and refine codes for large scale simulator test
Feb 12, 2025
s5u13b
changed the title
[Observability][GlobalScheduler][BugFix] Simplify request timestamps implementation & Support power-of-k-choice for dispatch & Fix some bugs and refine codes for large scale simulator test
[BugFix][Refactor] Fix some bugs and refine codes for large scale simulator test
Feb 12, 2025
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.