Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL: Use X9 to make AsyncQueue atomic #13529

Merged
merged 5 commits into from
Sep 19, 2024
Merged

DPL: Use X9 to make AsyncQueue atomic #13529

merged 5 commits into from
Sep 19, 2024

Conversation

ktf
Copy link
Member

@ktf ktf commented Sep 19, 2024

No description provided.

@ktf ktf requested a review from a team as a code owner September 19, 2024 11:05
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for f906546 at 2024-09-19 13:16:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/SOURCES/O2/13529-slc8_x86-64/0/Framework/Core/include/Framework/AsyncQueue.h:96:8: error: 'atomic' in namespace 'std' does not name a template type
/sw/SOURCES/O2/13529-slc8_x86-64/0/Framework/Core/src/AsyncQueue.cxx:48:51: error: 'struct o2::framework::AsyncQueue' has no member named 'first'
/sw/SOURCES/O2/13529-slc8_x86-64/0/Framework/Core/src/AsyncQueue.cxx:60:9: error: 'struct o2::framework::AsyncQueue' has no member named 'first'
ninja: build stopped: subcommand failed.

Full log here.

@ktf
Copy link
Member Author

ktf commented Sep 19, 2024

Tested on hyperloop as well. Merging.

@ktf ktf merged commit 8dddc15 into AliceO2Group:dev Sep 19, 2024
11 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants