Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL: introduce a --data-processing-timeout #13542

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

ktf
Copy link
Member

@ktf ktf commented Sep 26, 2024

Used to force stop the data processing and start the calibration.
In case it is larger than the exit-transition-timeout, the two will be coalesced
into a single transition.

For the time being the only side effect is to set the DeviceState::allowedProcessing and
to terminate the source devices earlier than the data processing ones.

Next PR will make sure that only calibrations are treated when DeviceState::allowedProcessing is set to ProcessingType::Calibration.

@ktf ktf requested a review from a team as a code owner September 26, 2024 10:23
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@ktf ktf force-pushed the pr13542 branch 2 times, most recently from 37ec795 to 80a0d94 Compare September 26, 2024 17:45
Used to force stop the data processing and start the calibration.
In case it is larger than the exit-transition-timeout, the two will be coalesced
into a single transition.

For the time being the only side effect is to set the DeviceState::allowedProcessing and
to terminate the source devices earlier than the data processing ones.

Next PR will make sure that only calibrations are treated when DeviceState::allowedProcessing is set to ProcessingType::Calibration.
@ktf
Copy link
Member Author

ktf commented Sep 27, 2024

@teo @davidrohr @shahor02 this is the first one of two PRs to enable the new calibration mode, as requested in https://its.cern.ch/jira/browse/O2-4308. This one in particular implements a new timer, configured via --data-processing-timeout, which will trigger the dual timer for non-source devices and make the sources transition to end of stream earlier. If the --data-processing-timeout option is omitted, it will behave as usual.

Notice that even if the dual time is there, for now it's merely printing out a different message and setting the DeviceState::allowedProcessing to CalibrationOnly, it will not yet enforce the new behaviour of discarding the non calibration inputs. The latter is coming via #13544, which I am still refining.

@ktf ktf merged commit aa88464 into AliceO2Group:dev Sep 27, 2024
19 checks passed
@ktf ktf deleted the pr13542 branch September 27, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant