Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITS: TrackExtensionStudy #13568

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from
Open

ITS: TrackExtensionStudy #13568

wants to merge 13 commits into from

Conversation

f3sch
Copy link
Collaborator

@f3sch f3sch commented Oct 4, 2024

The majority oft the changes extends the track extension study code. The rest makes minor modifications which should be safe. Also this fixes one bug for the track following where the vector iterator gets invalidate when the vector is reallocated.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@f3sch
Copy link
Collaborator Author

f3sch commented Nov 6, 2024

Undrafting to check CI.

@f3sch f3sch marked this pull request as ready for review November 6, 2024 08:13
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Avoid invalid read on first call.

Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@alibuild
Copy link
Collaborator

alibuild commented Nov 6, 2024

Error while checking build/O2/fullCI for eb3b349 at 2024-11-06 21:29:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/BUILD/8cc3e636284b982c7e6e6829031a0deabb760788/O2/Detectors/ITSMFT/ITS/tracking/GPU/hip/TrackingKernels.hip:845:47: error: use nullptr [modernize-use-nullptr]
/sw/BUILD/8cc3e636284b982c7e6e6829031a0deabb760788/O2/Detectors/ITSMFT/ITS/tracking/GPU/hip/TrackingKernels.hip:852:47: error: use nullptr [modernize-use-nullptr]
/sw/BUILD/8cc3e636284b982c7e6e6829031a0deabb760788/O2/Detectors/ITSMFT/ITS/tracking/GPU/hip/TrackingKernels.hip:937:47: error: use nullptr [modernize-use-nullptr]
/sw/BUILD/8cc3e636284b982c7e6e6829031a0deabb760788/O2/Detectors/ITSMFT/ITS/tracking/GPU/hip/TrackingKernels.hip:944:47: error: use nullptr [modernize-use-nullptr]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.


o2_add_test_root_macro(
PostTrackExtension.C
PUBLIC_LINK_LIBRARIES ROOT::Hist ROOT::RIO ROOT::Core ROOT::Gpad
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you need:

Suggested change
PUBLIC_LINK_LIBRARIES ROOT::Hist ROOT::RIO ROOT::Core ROOT::Gpad
PUBLIC_LINK_LIBRARIES ROOT::Hist ROOT::RIO ROOT::Core ROOT::Gpad fmt::fmt

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curiously, it still complains about it.

cling::DynamicLibraryManager::loadLibrary(): dlopen(libfmt.10.1.0.dylib, 0x0009): tried: 'libfmt.10.1.0.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OSlibfmt.10.1.0.dylib' (no such file), '/Volumes/build/alice-ci-workdir/o2/sw/osx_arm64/ROOT/v6-32-06-alice1-local3/lib/../lib/libfmt.10.1.0.dylib' (no such file), '/Volumes/build/alice-ci-workdir/o2/sw/osx_arm64/ROOT/v6-32-06-alice1-local3/bin/../lib/libfmt.10.1.0.dylib' (no such file), '/usr/lib/libfmt.10.1.0.dylib' (no such file, not in dyld cache), 'libfmt.10.1.0.dylib' (no such file)
cling::DynamicLibraryManager::loadLibrary(): dlopen(/Volumes/build/alice-ci-workdir/o2/sw/BUILD/e89aa9f3d18dea00fd76f985216d2b4e905e7c6c/O2/compiled_macros/Volumes/build/alice-ci-workdir/o2/sw/SOURCES/O2/13568/0/Detectors/ITSMFT/ITS/postprocessing/studies/macros/PostTrackExtension_C.so, 0x0009): Library not loaded: @rpath/libfmt.10.dylib
  Referenced from: <7E867859-82DA-3B84-9471-92E6AA6D43A1> /Volumes/build/alice-ci-workdir/o2/sw/BUILD/e89aa9f3d18dea00fd76f985216d2b4e905e7c6c/O2/compiled_macros/Volumes/build/alice-ci-workdir/o2/sw/SOURCES/O2/13568/0/Detectors/ITSMFT/ITS/postprocessing/studies/macros/PostTrackExtension_C.so
  Reason: tried: '/Volumes/build/alice-ci-workdir/o2/sw/osx_arm64/ROOT/v6-32-06-alice1-local3/lib/libfmt.10.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Volumes/build/alice-ci-workdir/o2/sw/osx_arm64/ROOT/v6-32-06-alice1-local3/lib/libfmt.10.dylib' (no such file), '/Volumes/build/alice-ci-workdir/o2/sw/osx_arm64/ROOT/v6-32-06-alice1-local3/lib/libfmt.10.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Volumes/build/alice-ci-workdir/o2/sw/osx_arm64/ROOT/v6-32-06-alice1-local3/lib/libfmt.10.dylib' (no such file), '/Volumes/build/alice-ci-workdir/o2/sw/osx_arm64/ROOT/v6-32-06-alice1-local3/lib/../lib/libfmt.10.dylib' (no such file), '/Volumes/build/alice-ci-workdir/o2/sw/osx_arm64/ROOT/v6-32-06-alice1-local3/bin/../lib/libfmt.10.dylib' (no such file)
ld: Undefined symbols:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curiously, it still complains about it.

cling::DynamicLibraryManager::loadLibrary(): dlopen(libfmt.10.1.0.dylib, 0x0009): tried: 'libfmt.10.1.0.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OSlibfmt.10.1.0.dylib' (no such file), '/Volumes/build/alice-ci-workdir/o2/sw/osx_arm64/ROOT/v6-32-06-alice1-local3/lib/../lib/libfmt.10.1.0.dylib' (no such file), '/Volumes/build/alice-ci-workdir/o2/sw/osx_arm64/ROOT/v6-32-06-alice1-local3/bin/../lib/libfmt.10.1.0.dylib' (no such file), '/usr/lib/libfmt.10.1.0.dylib' (no such file, not in dyld cache), 'libfmt.10.1.0.dylib' (no such file)
cling::DynamicLibraryManager::loadLibrary(): dlopen(/Volumes/build/alice-ci-workdir/o2/sw/BUILD/e89aa9f3d18dea00fd76f985216d2b4e905e7c6c/O2/compiled_macros/Volumes/build/alice-ci-workdir/o2/sw/SOURCES/O2/13568/0/Detectors/ITSMFT/ITS/postprocessing/studies/macros/PostTrackExtension_C.so, 0x0009): Library not loaded: @rpath/libfmt.10.dylib
  Referenced from: <7E867859-82DA-3B84-9471-92E6AA6D43A1> /Volumes/build/alice-ci-workdir/o2/sw/BUILD/e89aa9f3d18dea00fd76f985216d2b4e905e7c6c/O2/compiled_macros/Volumes/build/alice-ci-workdir/o2/sw/SOURCES/O2/13568/0/Detectors/ITSMFT/ITS/postprocessing/studies/macros/PostTrackExtension_C.so
  Reason: tried: '/Volumes/build/alice-ci-workdir/o2/sw/osx_arm64/ROOT/v6-32-06-alice1-local3/lib/libfmt.10.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Volumes/build/alice-ci-workdir/o2/sw/osx_arm64/ROOT/v6-32-06-alice1-local3/lib/libfmt.10.dylib' (no such file), '/Volumes/build/alice-ci-workdir/o2/sw/osx_arm64/ROOT/v6-32-06-alice1-local3/lib/libfmt.10.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Volumes/build/alice-ci-workdir/o2/sw/osx_arm64/ROOT/v6-32-06-alice1-local3/lib/libfmt.10.dylib' (no such file), '/Volumes/build/alice-ci-workdir/o2/sw/osx_arm64/ROOT/v6-32-06-alice1-local3/lib/../lib/libfmt.10.dylib' (no such file), '/Volumes/build/alice-ci-workdir/o2/sw/osx_arm64/ROOT/v6-32-06-alice1-local3/bin/../lib/libfmt.10.dylib' (no such file)
ld: Undefined symbols:

This is the exact error you had before, right? So my suggestion was pointless 👎🏼

Copy link
Collaborator Author

@f3sch f3sch Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well correct to link it nonetheless but yes it did not fix it and stayed the same. But I kind of am out of ideas what else to add, must be something insanely obvious

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ktf Sorry to bother you but do you have an idea what I am missing in the linking?

@alibuild
Copy link
Collaborator

alibuild commented Nov 12, 2024

Error while checking build/O2/fullCI for 86c943b at 2024-11-12 05:02:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/BUILD/aff7a64cab769e54792c8f03f154eb492777fdd9/O2/Detectors/ITSMFT/ITS/tracking/GPU/hip/TrackingKernels.hip:845:47: error: use nullptr [modernize-use-nullptr]
/sw/BUILD/aff7a64cab769e54792c8f03f154eb492777fdd9/O2/Detectors/ITSMFT/ITS/tracking/GPU/hip/TrackingKernels.hip:852:47: error: use nullptr [modernize-use-nullptr]
/sw/BUILD/aff7a64cab769e54792c8f03f154eb492777fdd9/O2/Detectors/ITSMFT/ITS/tracking/GPU/hip/TrackingKernels.hip:937:47: error: use nullptr [modernize-use-nullptr]
/sw/BUILD/aff7a64cab769e54792c8f03f154eb492777fdd9/O2/Detectors/ITSMFT/ITS/tracking/GPU/hip/TrackingKernels.hip:944:47: error: use nullptr [modernize-use-nullptr]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants