Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readout-proxy: correctly populate TimingInfo #8606

Merged
merged 3 commits into from
Apr 22, 2022

Conversation

ktf
Copy link
Member

@ktf ktf commented Apr 18, 2022

No description provided.

@ktf ktf requested a review from a team as a code owner April 18, 2022 21:14
@davidrohr
Copy link
Collaborator

thx, will try to test tomorrow!

@ktf
Copy link
Member Author

ktf commented Apr 20, 2022

This was all green and the errors are actually unrelated (bumped glibc on CS8). Is it ok to merge it?

ktf added 3 commits April 21, 2022 17:12
This is required to have a proper firstTFOrbit message, since
the PreProcessingCallback happens too early in the case of
the readout proxy.
@ktf
Copy link
Member Author

ktf commented Apr 21, 2022

@davidrohr @shahor02 Ok, this works. Checked on my box. There are two issues:

  • TimingInfo was not getting populated in the first place.
  • The message comes too early for the way the readout-proxy works, so I introduced a callback which is invoked after the processing has happened.

This means that for now we need two messages per timeframe and only the "done" one will get the correct firstTFOrbit.

@ktf
Copy link
Member Author

ktf commented Apr 21, 2022

E.g.:

[11171:raw-file-reader]: [16:57:19][INFO] Processing timeslice:3, tfCounter:3, firstTFOrbit:0, action:0
[11171:raw-file-reader]: [16:57:19][INFO] Starting new loop 3 from the beginning of data
[11171:raw-file-reader]: [16:57:19][INFO] Reading TF#3 (0 at iteration 3)
[11171:raw-file-reader]: [16:57:25][INFO] Sending 190913 parts to channel dpl-chan
[11171:raw-file-reader]: [16:57:25][INFO] Sent payload of 100170876 bytes in 190913 parts in 1 messages for TF#3 firstTForbit=1 timeStamp
=1650546674845 | Timing (total/IO): 0.5800000000000001 / 0.29000000000000103
[11171:raw-file-reader]: [16:57:25][INFO] Done processing timeslice:3, tfCounter:3, firstTFOrbit:1, action:0

@ktf
Copy link
Member Author

ktf commented Apr 21, 2022

To properly fix this we would need to move the readout-proxy to use Lifetime::OutOfBand, which then injects data at the right moment like any other input.

@davidrohr davidrohr merged commit c47ee03 into AliceO2Group:dev Apr 22, 2022
@ktf ktf deleted the timing-info-readout-proxy branch April 22, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants