Fix Partition<Filtered>, add separate sliceByCached for joins, filtered and nested filtered #8626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ktf @aalkin
the Join method is a copy of the Table
sliceByCached()
, and Filtered is a copy of FilteredBase method. The problem is in returning exact O2 table type, what apparently cannot be done without copies or makingsliceByCached()
a standalone function and changing the UI. I need the exact type so as to usesliceByCached()
for faster event mixing, which will come in another PR.The changes in Partition constructor fix a newly discovered bug in creating Partitions on Filtered. The buggy methods were called when creating
Partitions<Filtered>
insideprocess()
or callingsliceByCached()
onPartitions<Filtered>
.