MUON: add remote workflows for fwd matched tracks #638
Conversation
This adds a new switch to enable/disable the QC node workflows for forward matched racks, similar to what is already done for ITS-TPC. Three alternative workflows are selected depending on the list of detectors (MFT/MCH/MID) included in the data taking.
| - name: qc-remote-workflow-fwd # GLO is not a detector so we won't iterate on it with 'detectors' and we need special enable logic | ||
| enabled: "{{ 'MCH' in json.Unmarshal(detectors) }}" | ||
| vars: | ||
| qc_remote_workflow: "{{ util.PrefixedOverride( 'qc_remote_workflow', 'glo' ) }}" |
There was a problem hiding this comment.
@knopers8 it is ok to use the glo prefix for the workflow in two separate rules?
There was a problem hiding this comment.
Well, i don't think this variable is used for generating the actual workflow. It is probably a leftover of earlier approaches.
The only potential issue I can see is that qc_remote_workflow != 'none' is used to enable shmem cleanup. While I see in a prod environment that it is not enabled, to be on the safe side, I would propose to remove the fairmq-shmmonitor from this role and from the role qc-remote-workflow-glo.
The problem with this could appear if we have two environments, one for ITS, one for MCH, running at the same time. The first one to be destroyed will affect the rest of the processing of the other environment on the same machine.
There was a problem hiding this comment.
@knopers8 thanks! I have removed the fairmq-shmmonitor from the two roles. I will organize a test in production with replay data to check that all is fine, and post here the outcome. The initial version was already checked in staging.
|
@vascobarroso @knopers8 @teo could you please have a look and check if it is all good? Thanks! |
…mote-workflow-fwd roles
|
@aferrero2707 @knopers8 should this go into production tomorrow with the deployment ? |
This adds a new switch to enable/disable the QC node workflows for forward matched racks, similar to what is already done for ITS-TPC.
Three alternative workflows are selected depending on the list of detectors (MFT/MCH/MID) included in the data taking.