[QC-429] Trending tasks should use End Of Validity for point timestamps #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs #1845, but can be already reviewed. |
knopers8
changed the title
Barthelemy
approved these changes
Jun 27, 2023
|
Do we need more reviews or can I merge ? |
|
Yes, I would appreciate a cross-check of the task owners ( @wiechula , @njacazio , @aferrero2707 , @sbysiak , @bazinski ). |
bazinski
approved these changes
Jun 28, 2023
wiechula
approved these changes
Jun 29, 2023
aferrero2707
approved these changes
Jun 29, 2023
|
@knopers8 There seems to be a legit issue now with the checks. |
If trended objects follow the new validity rules, they should use the end of validity as the timestamp of a data point, since the start will be usually the same (SOR). I did not touch tasks which use creation time or current timestamp instead, since these will not be affected by the change. FIT tasks have a way to select what kind of timestamps should be used, so I added a new option for "validUntil".
|
Yes, bad merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If trended objects follow the new validity rules, they should use the end of validity as the timestamp of a data point, since the start will be usually the same (SOR). I did not touch tasks which use creation time or current timestamp instead, since these will not be affected by the change. FIT tasks have a way to select what kind of timestamps should be used, so I added a new option for "validUntil".