-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MFT: fixed displaying of dead chips in digit maps #1900
MFT: fixed displaying of dead chips in digit maps #1900
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, perhaps using this method would also work for you? This uses the CCDB specified in qc.config.conditionDB.url
:
T* retrieveConditionAny(std::string const& path, std::map<std::string, std::string> const& metadata = {}, long timestamp = -1); |
Modules/MFT/src/QcMFTDigitCheck.cxx
Outdated
{ | ||
o2::ccdb::CcdbApi api; | ||
api.init(mDeadMapCcdbAddress.data()); | ||
long timestamp = -1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are going to use this check in async processing, this might request a wrong object, not matching the time of data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a standardised way of accessing CCDBB objects with the validity corresponding to the data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not well exercised, but... UserCodeInterface::retrieveConditionAny
would be the method to use and the timestamp could be mo->getValidity().getMin()
, which now is still the time of creating an object, but soon it will be SOR in case of integrated plots and the cycle start in case of moving windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for pointing us to this. I modified the code using the methods you suggested.
Object mNOfDigitsTime bigger than maximum allowed size
andObject mNOfDigitsTime will not be uploaded
)