Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFT: fixed displaying of dead chips in digit maps #1900

Merged
merged 4 commits into from
Jul 31, 2023

Conversation

tomas-herman
Copy link
Collaborator

  • displaying of excluded (dead or masked) chips in the digit chip maps using the beautifier
  • removal of redundant mNOfDigitsTime histogram that was causing messages in FLP infologgers (Object mNOfDigitsTime bigger than maximum allowed size and Object mNOfDigitsTime will not be uploaded)

Copy link
Collaborator

@knopers8 knopers8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, perhaps using this method would also work for you? This uses the CCDB specified in qc.config.conditionDB.url:

T* retrieveConditionAny(std::string const& path, std::map<std::string, std::string> const& metadata = {}, long timestamp = -1);

{
o2::ccdb::CcdbApi api;
api.init(mDeadMapCcdbAddress.data());
long timestamp = -1;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are going to use this check in async processing, this might request a wrong object, not matching the time of data.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a standardised way of accessing CCDBB objects with the validity corresponding to the data?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not well exercised, but... UserCodeInterface::retrieveConditionAny would be the method to use and the timestamp could be mo->getValidity().getMin(), which now is still the time of creating an object, but soon it will be SOR in case of integrated plots and the cycle start in case of moving windows.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for pointing us to this. I modified the code using the methods you suggested.

@knopers8 knopers8 enabled auto-merge (squash) July 31, 2023 15:29
@knopers8 knopers8 merged commit c9a007d into AliceO2Group:master Jul 31, 2023
2 checks passed
@tomas-herman tomas-herman deleted the mft-dead-chip-digit-update branch August 1, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants