New trending plot of GTB Links decoding errors #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsakovAD
changed the title
IsakovAD
reviewed
Aug 9, 2023
IsakovAD
reviewed
Aug 9, 2023
| @@ -65,6 +65,7 @@ void ReductorBinContent::update(TObject* obj) | |||
| int numberOfBinsY = histo->GetYaxis()->GetNbins(); | |||
|
|
|||
| for (int j = 1; j <= numberOfBinsY; j++) { | |||
| std::cout << "at bin : " << j << " filled by : " << histo->Integral(1, numberOfBinsX, j, j) << std::endl; | |||
IsakovAD
reviewed
Aug 9, 2023
|
|
||
| for (const auto& source : mConfig.dataSources) { | ||
| std::unique_ptr<ReductorBinContent> reductor(root_class_factory::create<ReductorBinContent>(source.moduleName, source.reductorName)); | ||
| reductor->setParams(22, 0); |
There was a problem hiding this comment.
Could you define "22" as some "const int" variable in the header?
This 22 corresponds to the number of error plots provided by your code
|
@selindra Thank you for PR. Let`s see how the situation with build errors evolve after solving my comments |
IsakovAD
changed the title
|
Could you please add your approval to this PR? We need to have one more review, but Ivan is out of office for this week |
knopers8
approved these changes
Aug 15, 2023
|
Same as with the other PR, it is waiting for Ivan's review specifically. I will force-merge as soon as the macOS check goes green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plot shows how the amount of GTBLinks decoding errors was changing throughout the time. Was based on ITSqcTrendingFEE graph.