[QC-996] policy multiple_per_run can delete first and last #1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barthelemy
force-pushed
the
delete-last-first
branch
from
84d75a6
to
f45f73f
Compare
Barthelemy
changed the title
knopers8
reviewed
Aug 30, 2023
Barthelemy
commented
Sep 6, 2023
| preservation_list.extend(run_versions) | ||
| continue | ||
| # flag second with `cleaner_2nd` | ||
| ccdb.updateValidity(run_versions[1], run_versions[1].validFrom, run_versions[1].validTo, |
There was a problem hiding this comment.
@knopers8 I think that here we should not actually update the validity right ?
There was a problem hiding this comment.
now we probably never should update validity
There was a problem hiding this comment.
ah wait, my bad, this is actually not touching the validity but adds the flag.
There was a problem hiding this comment.
@knopers8 is it ok ? it is not touching the validity, it is just using this method to add the flag.
There was a problem hiding this comment.
yes, but perhaps we should have another method for doing this.
There was a problem hiding this comment.
I have created a dedicated method. Behind the scene we still have to specify the validity due to the way the CCDB rest api works.
… requires to specify the start of validity behind the scene.
knopers8
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.