Enable TrkPID QC #2036
Enable TrkPID QC #2036
Conversation
njacazio
force-pushed
the
nj-2dmatching
branch
from
ae1513c to
a7eda72
Compare
| @@ -99,72 +106,7 @@ void ITSTPCMatchingTask::initialize(o2::framework::InitContext& /*ctx*/) | |||
|
|
|||
| mMatchITSTPCQC.initDataRequest(); | |||
| mMatchITSTPCQC.init(); | |||
|
|
|||
There was a problem hiding this comment.
@chiarazampolli I changed the way we publish the histograms so that we don't need to duplicate the PRs. I can avoid it if you think it's unecessary
njacazio
force-pushed
the
nj-2dmatching
branch
from
a7eda72 to
c442303
Compare
| @@ -42,6 +42,13 @@ void ITSTPCMatchingTask::initialize(o2::framework::InitContext& /*ctx*/) | |||
| } | |||
| } | |||
|
|
|||
| if (auto param = mCustomParameters.find("useTrkPID"); param != mCustomParameters.end()) { | |||
| ILOG(Debug, Devel) << "Custom parameter - useTrkPID (= add plots for tracking PID): " << param->second << ENDM; | |||
| if (param->second == "true" || param->second == "True" || param->second == "TRUE") { | |||
There was a problem hiding this comment.
bool stringUtils::decodeBool(const std::string& value) does the same as this condition.
There was a problem hiding this comment.
thanks, I implemented it! Also, while looking for decodeBool in the QualityControl I found several implementations, maybe this can be unified
| getObjectsManager()->startPublishing(mMatchITSTPCQC.getHistoTimeResVsPt()); | ||
|
|
||
| getObjectsManager()->startPublishing(mMatchITSTPCQC.getHistoDCAr()); | ||
| mMatchITSTPCQC.publishHistograms(getObjectsManager()); |
There was a problem hiding this comment.
Is publishHistograms used somewhere else ? or just in QC ?
There was a problem hiding this comment.
I think just in QC, it is not the only way to access the histogram and publish them, however like this one does not need to have 2 PRs in order to publish all the histograms and one in the O2 is enough.
depends on AliceO2Group/AliceO2#12258