Allow for TFID == 0 in async QC timekeeping for testing purposes #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it has been demonstrated by a recent use case, some simulated data does not use correct TFID, having it as 0 instead. In such cases, we do not want to block the users from testing their sw, thus we allow for it and produce a warning. We overwrite TFID to 1, so it does not break the algorithm which computes the data timespan (production data starts with TFID == 1)
Barthelemy
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it has been demonstrated by a recent use case, some simulated data does not use correct TFID, having it as 0 instead. In such cases, we do not want to block the users from testing their sw, thus we allow for it and produce a warning. We overwrite TFID to 1, so it does not break the algorithm which computes the data timespan (production data starts with TFID == 1)