Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

since too long data description is now safe, no need to warn #2301

Merged
merged 1 commit into from
May 27, 2024

Conversation

knopers8
Copy link
Collaborator

I think it's enough to have a debug log now, the warnings generate quite a lot of noise at the moment, while "too long" description is now safe to have.

I think it's enough to have a debug log now, the warnings generate quite a lot of noise at the moment, while "too long" description is now safe to have.
@knopers8
Copy link
Collaborator Author

See a typical global staging environment start to understand how many warnings we get.

@Barthelemy
Copy link
Collaborator

@ktf there seems to be an issue with with the O2 build on MacOS-arm:

## sw/BUILD/O2-latest/log
 22/501 Test  #19: framework:crash ......................................................................***Failed    3.48 sec

Copy link
Collaborator

@Barthelemy Barthelemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed

@Barthelemy Barthelemy enabled auto-merge (squash) May 27, 2024 12:48
@Barthelemy Barthelemy merged commit 7a96e8a into master May 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants