QC-1155 Allow for multiple graphs in one canvas in TrendingTask #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to draw more than one histogram or TGraph on one plot (canvas) in TrendingTask. If more than one graph is used, a legend is automatically added to the plot. The configuration scheme has been adapted accordingly to allow for multiple graphs. The old way is still supported, but has been removed from documentation to encourage users to move to the new scheme. There is also a possibility to select custom color palette expected, but we will need ROOT bump to 6.32 before this can be enabled. Some refactoring is included as well.
Barthelemy
approved these changes
Jun 17, 2024
| @@ -66,8 +64,15 @@ class TrendingTask : public PostProcessingInterface | |||
| } | |||
| } mMetaData; | |||
|
|
|||
| static void setUserAxisLabel(TAxis* xAxis, TAxis* yAxis, const std::string& graphAxisLabel); | |||
There was a problem hiding this comment.
not sure, but shouldn't it be setUserAxesLabel ? there are several axes.
There was a problem hiding this comment.
Well, you wrote this method :D but agreed, I will rename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to draw more than one histogram or TGraph on one plot (canvas) in TrendingTask. If more than one graph is used, a legend is automatically added to the plot.
The configuration scheme has been adapted accordingly to allow for multiple graphs. The old way is still supported, but has been removed from documentation to encourage users to move to the new scheme.
There is also a possibility to select custom color palette expected, but we will need ROOT bump to 6.32 before this can be enabled.
Some refactoring is included as well.