Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TPC: Adds Separation power of pions and electrons with mergable objects. #2343

Merged
merged 8 commits into from
Sep 2, 2024
Merged

TPC: Adds Separation power of pions and electrons with mergable objects. #2343

merged 8 commits into from
Sep 2, 2024

Conversation

HorstMa
Copy link
Contributor

@HorstMa HorstMa commented Jun 17, 2024

similar to #2225, but with mergable objects. replaced the TPaveText with a TProfile and removed the TF1.

@HorstMa HorstMa requested a review from wiechula as a code owner June 17, 2024 10:59
wiechula
wiechula requested changes Jun 18, 2024
View reviewed changes
Modules/TPC/include/TPC/PID.h Outdated Show resolved Hide resolved
Modules/TPC/src/PID.cxx Outdated Show resolved Hide resolved
Modules/TPC/include/TPC/PID.h Outdated Show resolved Hide resolved
Modules/TPC/src/PID.cxx Outdated Show resolved Hide resolved
Modules/TPC/src/PID.cxx Outdated Show resolved Hide resolved
Modules/TPC/src/PID.cxx Outdated Show resolved Hide resolved
Modules/TPC/src/PID.cxx Outdated Show resolved Hide resolved
@knopers8
Copy link
Collaborator

knopers8 commented Jul 4, 2024

the issue in the macOS CI looks correlated with the PR:

/Volumes/build/alice-ci-workdir/qualitycontrol-o2/sw/SOURCES/QualityControl/2343/0/Modules/TPC/src/PID.cxx:124:33: error: variable-sized object may not be initialized
        const TString binLabels[nPars] = { "Amplitude Pi", "Mean Pi", "Sigma Pi", "Amplitude El", "Mean El", "Sigma El", "Separation Power", "chiSquare/ndf" };
                                ^~~~~
1 error generated.

@wiechula wiechula changed the title Adds Separation power of pions and electrons with mergable objects. TPC: Adds Separation power of pions and electrons with mergable objects. Jul 4, 2024
wiechula
wiechula requested changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@wiechula wiechula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @HorstMa , a few more things.

Modules/TPC/src/PID.cxx Outdated Show resolved Hide resolved
Modules/TPC/include/TPC/PID.h Outdated Show resolved Hide resolved
Modules/TPC/src/PID.cxx Outdated Show resolved Hide resolved
@HorstMa
Copy link
Contributor Author

HorstMa commented Aug 7, 2024

@wiechula I added the requested changes

wiechula
wiechula requested changes Aug 9, 2024
View reviewed changes
Modules/TPC/src/PID.cxx Outdated Show resolved Hide resolved
@HorstMa
Copy link
Contributor Author

HorstMa commented Aug 13, 2024

@wiechula I added the change.

@wiechula wiechula merged commit 62eedb5 into AliceO2Group:master Sep 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiechula wiechula wiechula approved these changes

@andreasmolander andreasmolander Awaiting requested review from andreasmolander

@afurs afurs Awaiting requested review from afurs

@iravasen iravasen Awaiting requested review from iravasen

@IsakovAD IsakovAD Awaiting requested review from IsakovAD

@diana0x0f diana0x0f Awaiting requested review from diana0x0f

@mfasDa mfasDa Awaiting requested review from mfasDa

@jokonig jokonig Awaiting requested review from jokonig

@Barthelemy Barthelemy Awaiting requested review from Barthelemy

@knopers8 knopers8 Awaiting requested review from knopers8

@justonedev1 justonedev1 Awaiting requested review from justonedev1

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HorstMa @knopers8 @wiechula