Common: add generic checker for trending plots #2383
Conversation
aferrero2707
requested review from
Barthelemy,
knopers8 and
justonedev1
as code owners
The `std::string` type was not correctly handled because the standard library does not provide an "identity" override for `std::to_string()`
The ultility class provides the following functionalities: * stores interaction-rate-dependent threshold values * stores optional axis ranges on which the check should be restricted * provides the code to retrieve the threshold and range values from the custom parameters * provides a function to retrieve the optimal threshold values for a given interaction rate
The checker is designed to verify that the values of trend graphs are within given minimum and maximum limits. The limits can be specified as fixed values, or values relative to either the mean or the standard deviation of a given set of graph points.
aferrero2707
force-pushed
the
common-add-generic-trend-checker
branch
from
9f337bf
to
83fdd47
Compare
aferrero2707
changed the title
|
@Barthelemy @knopers8 this PR is rather big, but it does not touch existing code, it only introduces a new checker + some utility class to handle the configuration parameters. More details are given in the JIRA ticket linked in the description. |
|
@Barthelemy would you have the possibility to review this PR in the next days? Apart from the support for rate-dependent checker thresholds (which might only be useful at a later stage), the code could be already used to check the trends of the raw and CTF sizes, for example, and to replace the custom checker for the vertex positions and sigmas. |
|
@aferrero2707 yes, apologies, this slipped through some hole and disappeared from my radar. |
|
@Barthelemy thanks for reviewing!
Yes, I was indeed planning to do that, I just wanted to wait for the first feedback in case it would required significant re-work. |
|
@aferrero2707 You can put it in Advanced.md for now. I will refactor the doc and move all the info about common in a separate file. |
|
@Barthelemy I did the suggested change and added the documentation. Let me know if all is good for you. |
The checker is designed to verify that the values of trend graphs are within given minimum and maximum limits.
The limits can be specified as fixed values, or values relative to either the mean or the standard deviation of a given set of graph points.
See https://its.cern.ch/jira/browse/QC-1216 for more details.