Common: add generic checker for trending plots #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aferrero2707
requested review from
Barthelemy,
knopers8 and
justonedev1
as code owners
The `std::string` type was not correctly handled because the standard library does not provide an "identity" override for `std::to_string()`
The ultility class provides the following functionalities: * stores interaction-rate-dependent threshold values * stores optional axis ranges on which the check should be restricted * provides the code to retrieve the threshold and range values from the custom parameters * provides a function to retrieve the optimal threshold values for a given interaction rate
The checker is designed to verify that the values of trend graphs are within given minimum and maximum limits. The limits can be specified as fixed values, or values relative to either the mean or the standard deviation of a given set of graph points.
aferrero2707
force-pushed
the
common-add-generic-trend-checker
branch
from
9f337bf
to
83fdd47
Compare
aferrero2707
changed the title
|
@Barthelemy @knopers8 this PR is rather big, but it does not touch existing code, it only introduces a new checker + some utility class to handle the configuration parameters. More details are given in the JIRA ticket linked in the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checker is designed to verify that the values of trend graphs are within given minimum and maximum limits.
The limits can be specified as fixed values, or values relative to either the mean or the standard deviation of a given set of graph points.
See https://its.cern.ch/jira/browse/QC-1216 for more details.