Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use int8_t rather than char #2386

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use int8_t rather than char #2386

wants to merge 1 commit into from
+12 −12

Conversation

ktf
Copy link
Member

@ktf ktf commented Aug 14, 2024

Sign of char is architecture dependent

Use int8_t rather than char
92a56d6 
Sign of char is architecture dependent
@Barthelemy
Copy link
Collaborator

Barthelemy commented Aug 15, 2024 •
edited
Loading

@ktf I think that it would require changes in PHOS code in O2 too...

@ktf
Copy link
Member Author

ktf commented Aug 15, 2024

Yes, I need to think how to decouple them...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Barthelemy Barthelemy Awaiting requested review from Barthelemy Barthelemy is a code owner

@knopers8 knopers8 Awaiting requested review from knopers8 knopers8 is a code owner

@justonedev1 justonedev1 Awaiting requested review from justonedev1 justonedev1 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktf @Barthelemy