Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITS alignment monitoring (check with QCv20240903), revised 20240919 #2418

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

delico18
Copy link
Contributor

@delico18 delico18 commented Sep 12, 2024

New 14 plots(7, layer x 2, axis[z ~ alpide col, phi ~ alpide row] for ITS alignment monitoring are added.

  • Circle Fitter (in XY plane)
  • Line Fitter (in DZ plane), D is almost same as the path length of particle.

Based on Least Square Fit, we can observe the residual of particles' track, which we believe they will show the alignment quality of ITS.

Modules/ITS/src/ITSTrackTask.cxx Outdated Show resolved Hide resolved
Modules/ITS/itsTrack.json Outdated Show resolved Hide resolved
Modules/ITS/src/ITSTrackTask.cxx Outdated Show resolved Hide resolved
Modules/ITS/src/ITSTrackTask.cxx Outdated Show resolved Hide resolved
Modules/ITS/include/ITS/ITSTrackTask.h Outdated Show resolved Hide resolved
@iravasen
Copy link
Collaborator

I will apply the clang format at the end once all comments have been implemented

Modules/ITS/itsTrack.json Show resolved Hide resolved
@delico18 delico18 closed this Sep 19, 2024
@delico18 delico18 reopened this Sep 19, 2024
@delico18 delico18 changed the title ITS alignment monitoring2 (check with QCv20240903) ITS alignment monitoring (check with QCv20240903) Sep 19, 2024
@delico18 delico18 changed the title ITS alignment monitoring (check with QCv20240903) [WIP] ITS alignment monitoring (check with QCv20240903), revised 20240919 Sep 19, 2024
@delico18
Copy link
Contributor Author

2024 09 19 update

There seems to be tiny errors in getting layer of cluster, and I corrected the lines.

Options...
to activate alignment monitoring(itsTrack.json) is added.
to request the minimum number of clusters / track for alignment monitoring(itsTrack.json) is added.

I updated the simple version of documentation that describes the fitting & residual calculation procedures.

Modules/ITS/src/ITSTrackTask.cxx Outdated Show resolved Hide resolved
Modules/ITS/src/ITSTrackTask.cxx Outdated Show resolved Hide resolved
@IsakovAD
Copy link
Collaborator

Hello,

Nice new feature! General comments:

  1. Size of new objects: I assume that TH2D is too much. Could you please check the size of objects in case of TH2D and TH2S/TH2I. I think that with such nice binning double is a quite overkill
  2. Try to minimize influence of your code when AlignmentMonitoring set to FALSE: do not initialize objects/do not download geometry etc. Please, check that task still working if user will set monitoring to OFF.

Otherwise, looking forward to results of this new feature

@delico18
Copy link
Contributor Author

delico18 commented Oct 21, 2024

The monitoring objects for residuals are now only activated when mAlignmentMonitor is true.
There is no more influence related to this object when this is set to false.

Please review this PR.(including TH2F vs TH2I)

@IsakovAD IsakovAD changed the title [WIP] ITS alignment monitoring (check with QCv20240903), revised 20240919 ITS alignment monitoring (check with QCv20240903), revised 20240919 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants