Common: reference comparator check improvements #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following changes are implemented for the object comparator interface: * optional X and Y ranges to restrict the comparison to a given histogram area * the comparators now access directly the custom parameters; this allows to have parameters specific to each comparator
The comparison based on the relative deviation between each bin of the current and reference histograms. A `maxAllowedBadBins` parameter allows to specify the maximum number of bins above threshold for which the quality is still considered Good. If X and/or Y ranges are specified, only the bins inside the ranges are considered for the comparison.
The "average deviation" and "Chi2 test" comparison methods are improved to take into account the X and/or Y ranges in the comparison.
* comparators are now plot-specific, allowing to have configuration parameters that are specific to some plots * for 1-D histograms, if specified the X range is shown on the ratio plot with a double-arrow horizontal line
aferrero2707
requested review from
Barthelemy,
knopers8 and
justonedev1
as code owners
The `std::string` type was not correctly handled because the standard library does not provide an "identity" override for `std::to_string()`
|
thank you, |
aferrero2707
force-pushed
the
common-reference-comparator-check-improvements
branch
from
a56f2b6 to
7524461
Compare
Barthelemy
approved these changes
Sep 25, 2024
aferrero2707
deleted the
common-reference-comparator-check-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several improvements to the reference comparator check:
ObjectComparatorBinByBinDeviationclass that checks the relative deviation between each bin of the current and reference histogramsmaxAllowedBadBinsparameter allows to specify the maximum number of bins above threshold for which the quality is still considered Good.