Common: support varibale bins in reference comparator output #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aferrero2707
requested review from
Barthelemy,
knopers8 and
justonedev1
as code owners
|
@Barthelemy @knopers8 @justonedev1 again a requests from detector experts, only requiring rather trivial changes. |
knopers8
approved these changes
Sep 25, 2024
aferrero2707
changed the title
auto-merge was automatically disabled
September 25, 2024 17:07
Head branch was pushed to by a user without write access
aferrero2707
force-pushed
the
common-support-variable-bin-size-in-reference-comparator
branch
from
1c9f72b
to
b259543
Compare
aferrero2707
changed the title
|
@knopers8 I had to change a bit the code, because the use of the |
The changes allow to properly display histograms with variable bin sizes in the output of the reference comparator task.
aferrero2707
force-pushed
the
common-support-variable-bin-size-in-reference-comparator
branch
from
b259543
to
7aef72b
Compare
aferrero2707
deleted the
common-support-variable-bin-size-in-reference-comparator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes allow to properly display histograms with variable bin sizes in the output of the reference comparator task.
Here is an example of variable bin size histogram compared to reference:
