MUON: introduce station-dependent checker thresholds #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aferrero2707
requested review from
Barthelemy,
knopers8 and
justonedev1
as code owners
Checker thresholds are extended to allow setting different values for specific stations, overriding the global default value. The code is also simplified by removing check of the ratio plots, that are now superseded by the common reference comparator output.
aferrero2707
force-pushed
the
mch-allow-station-dependent-checker-thresholds
branch
from
7b299af to
094d99f
Compare
|
@knopers8 @Barthelemy @justonedev1 this are some improvements to the MCH checkers needed to give more granularity in the applied thresholds. Would be nice to have this added flexibility for HI. I also took the opportunity to start some code cleanup, removing parts that are not really used. |
Barthelemy
approved these changes
Oct 4, 2024
aferrero2707
deleted the
mch-allow-station-dependent-checker-thresholds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checker thresholds are extended to allow setting different values for specific stations, overriding the global default value.
The code is also simplified by removing checks of the ratio plots, that are now superseded by the common reference comparator output.