feat(config): Allow loading extra config from file #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dasJ
force-pushed
the
feat/extra-config-file
branch
from
8654f39
to
42e29ba
Compare
the-nic
reviewed
Jan 13, 2023
| @@ -163,6 +165,12 @@ + (void) prepareUserDefaults | |||
| for (count = 0; count < sizeof(confFiles)/sizeof(confFiles[0]); count++) | |||
| _injectConfigurationFromFile (configFromFiles, confFiles[count], logger); | |||
|
|
|||
| /* Fill/Override configuration with configuration stored in the extra | |||
| * config file */ | |||
| envFile = [[[NSProcessInfo processInfo] environment] objectForKey:@"SOGO_EXTRA_CONFIG_FILE"]; | |||
There was a problem hiding this comment.
It would be helpful if this was documented
There was a problem hiding this comment.
I totally agree. Do you have any pointer where an appropriate location would be?
There was a problem hiding this comment.
I also agree the documentation should be updated. I suggest modifying this part : https://github.com/Alinto/sogo/blob/master/Documentation/SOGoInstallationGuide.asciidoc#gnustep-environment-overview
|
Hi @dasJ thanks for contributing ! Can you update documentation ? |
WoodySlum
force-pushed
the
master
branch
2 times, most recently
from
e4c98fd
to
2258d5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.