fix: ignore os.ErrClosed error on repeated FileStream close operations #6762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also resolves the issue where S3 PutObject returns a 500 status code.
|
Thanks for opening this pull request! Please check out our contributing guidelines. |
xhofe
approved these changes
Jul 14, 2024
|
Congrats on merging your first pull request! We here at behavior bot are proud of you! |
ForSourceCodeAnalysis
pushed a commit
to ForSourceCodeAnalysis/alist
that referenced
this pull request
Aug 4, 2024
AlistGo#6762) Also resolves the issue where S3 PutObject returns a 500 status code.
Three-taile-dragon
pushed a commit
to loognsss/blist
that referenced
this pull request
Sep 26, 2024
AlistGo#6762) Also resolves the issue where S3 PutObject returns a 500 status code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, this resolves the issue where S3's PutObject returns a 500 status code, as seen in:
https://github.com/alist-org/alist/blob/9e0482afbb0d3490cf3d98d79fbd0f75b9ac6349/server/s3/backend.go#L315-L319
It also mitigates log spam caused by repeated file closures, detailed here:
https://github.com/alist-org/alist/blob/9e0482afbb0d3490cf3d98d79fbd0f75b9ac6349/internal/op/fs.go#L501-L505
Already tested by Alist S3 + restic S3 + 123pan